Skip to content

fix(linux/postins): allow running on rpm-ostree environments#4963

Merged
ReenigneArcher merged 2 commits intoLizardByte:masterfrom
ykshek:master
Apr 10, 2026
Merged

fix(linux/postins): allow running on rpm-ostree environments#4963
ReenigneArcher merged 2 commits intoLizardByte:masterfrom
ykshek:master

Conversation

@ykshek
Copy link
Copy Markdown
Contributor

@ykshek ykshek commented Apr 9, 2026

Description

Allow running postinst on rpm-ostree environments, more specifically for brew installs to allow Kernel Mode Setting.
Output of running the modified postinst script on Bazzite:

bazzite@bazzite:/var/home/username$ sudo /home/bazzite/postinst 
Loading uhid kernel module for DS5 emulation.
Setting CAP_SYS_ADMIN, CAP_SYS_NICE capabilities on Sunshine binary.
/usr/sbin/setcap cap_sys_admin,cap_sys_nice+p /var/home/linuxbrew/.linuxbrew/Cellar/sunshine-beta/2026.407.170539/bin/sunshine-2026.407.170539
CAP_SYS_ADMIN, CAP_SYS_NICE capabilities set on Sunshine binary.
Reloading udev rules.
Udev rules reloaded successfully.

And after running and restarting the sunshine service, the kernel mode setting capture method can be used.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@ykshek
Copy link
Copy Markdown
Contributor Author

ykshek commented Apr 9, 2026

This change would be rather useful for ublue images as currently they also just runs the same commands to enable kernel mode setting capture, just manually or via the ujust helper script. Would be especially useful after a brew update, because the path of the executable changes every update and setcap needs to be run every time that happens to make sure capture doesn't break.

@sonarqubecloud
Copy link
Copy Markdown

@ReenigneArcher ReenigneArcher changed the title fix(postins): allow running on rpm-ostree environments fix(linux/postins): allow running on rpm-ostree environments Apr 10, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Bundle Report

Bundle size has no change ✅

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.19%. Comparing base (d3330d1) to head (57913e0).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4963      +/-   ##
==========================================
- Coverage   18.20%   18.19%   -0.01%     
==========================================
  Files         108      108              
  Lines       23409    23409              
  Branches    10330    10330              
==========================================
- Hits         4261     4259       -2     
- Misses      14152    15886    +1734     
+ Partials     4996     3264    -1732     
Flag Coverage Δ
Archlinux 11.62% <ø> (ø)
FreeBSD-14.3-aarch64 ?
FreeBSD-14.3-amd64 13.79% <ø> (ø)
Homebrew-ubuntu-22.04 13.94% <ø> (ø)
Linux-AppImage 12.50% <ø> (ø)
Windows-AMD64 14.90% <ø> (ø)
Windows-ARM64 13.22% <ø> (+<0.01%) ⬆️
macOS-arm64 19.02% <ø> (ø)
macOS-x86_64 18.39% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 54 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3330d1...57913e0. Read the comment docs.

@ReenigneArcher ReenigneArcher merged commit 379242e into LizardByte:master Apr 10, 2026
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants