revert: "feat(linux/vulkan): enable RADV low-latency Vulkan Video encoding"#4989
Merged
ReenigneArcher merged 1 commit intoLizardByte:masterfrom Apr 14, 2026
Merged
Conversation
ReenigneArcher
changed the title
Bundle ReportBundle size has no change ✅ |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4989 +/- ##
==========================================
- Coverage 17.99% 17.99% -0.01%
==========================================
Files 108 108
Lines 23424 23424
Branches 10340 10340
==========================================
- Hits 4216 4214 -2
- Misses 15118 17694 +2576
+ Partials 4090 1516 -2574
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 47 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #4984. Removes
lowlatencyencfrom theRADV_PERFTESTenvironment variable.As @gschintgen pointed out in #4984 (comment), the
lowlatencyencflag inRADV_PERFTESTis a driver-level override that forces ultra-low-latency tuning regardless of what the application requests via the Vulkan API.This is redundant because Sunshine already passes the user-configured
vk.tunesetting to FFmpeg, which setstuningModeinVkVideoEncodeUsageInfoKHR(seevulkan_encode.c:796). RADV respects this API-level tuning parameter, so the env var is unnecessary and would override the user's chosen tuning setting (default isll, notull).The
AMD_DEBUG=lowlatencyencfor the RadeonSI/VA-API path is unaffected — that path does not have the same API-level tuning control.See Mesa MR discussion: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/40524#note_3384466
Screenshot
Issues Fixed or Closed
Fixes concern raised in #4984: #4984 (comment)
Roadmap Issues
Type of Change
Checklist
AI Usage