ci(windows): add linkage check#5118
Merged
Merged
Conversation
Bundle ReportBundle size has no change ✅ |
a8b82c8 to
ca4ac63
Compare
Add a GitHub Actions step that runs under msys2 to verify runtime linkage of built Windows executables. The step runs ldd on a set of binaries (build/sunshine.exe, build/tools/audio-info.exe, build/tools/dxgi-info.exe, build/tools/sunshinesvc.exe, build/tests/test_sunshine.exe), groups and logs the output, and fails CI if unexpected dependencies are found (missing libraries or references into toolchain/mingw/ucrt paths). zlib1.dll is allowed. This prevents shipping missing or toolchain-linked DLLs before the signing step.
ca4ac63 to
3985357
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5118 +/- ##
=========================================
Coverage ? 17.83%
=========================================
Files ? 111
Lines ? 24009
Branches ? 10620
=========================================
Hits ? 4281
Misses ? 15386
Partials ? 4342
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Add a GitHub Actions step that runs under msys2 to verify runtime linkage of built Windows executables. The step runs ldd on a set of binaries (build/sunshine.exe, build/tools/audio-info.exe, build/tools/dxgi-info.exe, build/tools/sunshinesvc.exe, build/tests/test_sunshine.exe), groups and logs the output, and fails CI if unexpected dependencies are found (missing libraries or references into toolchain/mingw/ucrt paths). zlib1.dll is allowed. This prevents shipping missing or toolchain-linked DLLs before the signing step.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage