Skip to content

ci(windows): add linkage check#5118

Merged
ReenigneArcher merged 1 commit into
masterfrom
ci/windows/ensure-proper-linkage
May 14, 2026
Merged

ci(windows): add linkage check#5118
ReenigneArcher merged 1 commit into
masterfrom
ci/windows/ensure-proper-linkage

Conversation

@ReenigneArcher
Copy link
Copy Markdown
Member

@ReenigneArcher ReenigneArcher commented May 14, 2026

Description

Add a GitHub Actions step that runs under msys2 to verify runtime linkage of built Windows executables. The step runs ldd on a set of binaries (build/sunshine.exe, build/tools/audio-info.exe, build/tools/dxgi-info.exe, build/tools/sunshinesvc.exe, build/tests/test_sunshine.exe), groups and logs the output, and fails CI if unexpected dependencies are found (missing libraries or references into toolchain/mingw/ucrt paths). zlib1.dll is allowed. This prevents shipping missing or toolchain-linked DLLs before the signing step.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Bundle Report

Bundle size has no change ✅

@ReenigneArcher ReenigneArcher force-pushed the ci/windows/ensure-proper-linkage branch from a8b82c8 to ca4ac63 Compare May 14, 2026 18:20
Add a GitHub Actions step that runs under msys2 to verify runtime linkage of built Windows executables. The step runs ldd on a set of binaries (build/sunshine.exe, build/tools/audio-info.exe, build/tools/dxgi-info.exe, build/tools/sunshinesvc.exe, build/tests/test_sunshine.exe), groups and logs the output, and fails CI if unexpected dependencies are found (missing libraries or references into toolchain/mingw/ucrt paths). zlib1.dll is allowed. This prevents shipping missing or toolchain-linked DLLs before the signing step.
@ReenigneArcher ReenigneArcher force-pushed the ci/windows/ensure-proper-linkage branch from ca4ac63 to 3985357 Compare May 14, 2026 19:17
@sonarqubecloud
Copy link
Copy Markdown

@ReenigneArcher ReenigneArcher merged commit 71e4da4 into master May 14, 2026
43 of 45 checks passed
@ReenigneArcher ReenigneArcher deleted the ci/windows/ensure-proper-linkage branch May 14, 2026 20:12
@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@71323d3). Learn more about missing BASE report.
⚠️ Report is 2 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5118   +/-   ##
=========================================
  Coverage          ?   17.83%           
=========================================
  Files             ?      111           
  Lines             ?    24009           
  Branches          ?    10620           
=========================================
  Hits              ?     4281           
  Misses            ?    15386           
  Partials          ?     4342           
Flag Coverage Δ
Archlinux 11.23% <ø> (?)
FreeBSD-14.3-amd64 13.37% <ø> (?)
Homebrew-ubuntu-22.04 13.58% <ø> (?)
Linux-AppImage 12.16% <ø> (?)
Windows-AMD64 14.84% <ø> (?)
Windows-ARM64 13.23% <ø> (?)
macOS-arm64 19.01% <ø> (?)
macOS-x86_64 18.37% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71323d3...3985357. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Latest Pre-Release v2026.513.230134 wont start - libicuin78.dll missing

1 participant