feat(web-ui): Added Filtering & Searching to the Apps page#5158
Merged
Conversation
- `Apps.html`: Created functions for `displayApps()` filtering & `resetSearchQuery()` - `Apps.html`: Created new div card section for rendering out the no search results text - `Apps.html`: Changed the apps grid section to get it's data from the filtered `displayApps` function - `en.json`: Updated with new text variables for search - `sunshine.css`: Added styling for the `input-group` class
- `apps.html`: Created a new button that toggles through sorting of the apps names (config index based -> Ascending -> Descending) - `apps.html`: Created `sortModeLabel()` to return the label for the sorting type - `apps.html`: Updated the `displayedApps()` function with the sorting logic for displaying - `apps.html`: Created `toggleSort()` to rotate through the sorting types - `en.json`: Added sorting text
…come active when toggling
Bundle ReportChanges will increase total bundle size by 2.06kB (0.13%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sunshine-esmAssets Changed:
Files in
Files in
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5158 +/- ##
==========================================
- Coverage 17.88% 17.87% -0.01%
==========================================
Files 111 111
Lines 24120 24120
Branches 10665 10665
==========================================
- Hits 4313 4311 -2
+ Misses 17203 14665 -2538
- Partials 2604 5144 +2540
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated the Applications page to include the following:
default(app.json index based) ->Ascending->DescendingApplications (X)orApplications (X / Y)if filtering1 of 3, but unsure how languages translateofin this context.no_applicationsinen.jsonScreenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage