fix: explicitly check construct function error in thread_safe.h#5184
Merged
ReenigneArcher merged 1 commit intoMay 25, 2026
Merged
Conversation
|
Kishi85
changed the title
ReenigneArcher
approved these changes
May 25, 2026
Bundle ReportBundle size has no change ✅ |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5184 +/- ##
==========================================
- Coverage 17.81% 17.80% -0.01%
==========================================
Files 111 111
Lines 24143 24143
Branches 10687 10687
==========================================
- Hits 4301 4299 -2
+ Misses 14681 14667 -14
- Partials 5161 5177 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Explicitly check if the constructor was erroring out in thread_safe.h as the implicit writing does somehow not seem to catch all cases.
This is the reason for #5163 as the audio socket binding fails there. The constructor function (start_broadcast) is returning -1 in that case but instead of returning a nullptr ref it's using the created but broken broadcast_ctx instead from there on and continues to use it despite the broken audio_socket binding causing a segfault after a few retries.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage