Skip to content

Exclude .git from source RPMs#49

Closed
stephank wants to merge 1 commit intoLizardByte:masterfrom
stephank:patch-1
Closed

Exclude .git from source RPMs#49
stephank wants to merge 1 commit intoLizardByte:masterfrom
stephank:patch-1

Conversation

@stephank
Copy link
Copy Markdown

Description

I had a need to rebuild an old Sunshine for a newer Fedora, and noticed SRPMs are huge (1.3 GB), of which the bulk appears to be .git. A local build without it present seems to work fine, so consider removing it using --exclude-vcs. (Though I don't know how to test your CI.)

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sonarqubecloud
Copy link
Copy Markdown

@ReenigneArcher
Copy link
Copy Markdown
Member

Thank you for the PR. Could you sign the cla?

@stephank
Copy link
Copy Markdown
Author

Sorry, I prefer not to. But this is so tiny, consider it public domain. Feel free to strip authorship.

@ReenigneArcher
Copy link
Copy Markdown
Member

The large .git directory in Sunshine is a result of the build-deps submodule.

This has been fixed in the following PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants