Skip to content

fix(Windows): queue VHF input reports - #77

Merged
ReenigneArcher merged 2 commits into
masterfrom
fix/windows/latency-improvements
Aug 15, 2026
Merged

fix(Windows): queue VHF input reports#77
ReenigneArcher merged 2 commits into
masterfrom
fix/windows/latency-improvements

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Add a bounded VHF input-report queue for the UMDF backend so reports are only submitted when VHF signals readiness. Continuous state updates now coalesce to the latest value while discrete button, D-pad, trigger-threshold, report-ID, and touch-contact transitions stay ordered, and Switch protocol replies are prioritized to keep the handshake responsive. Also document the buffering policy and add unit coverage for queue behavior across supported Windows gamepad profiles.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Add a bounded VHF input-report queue for the UMDF backend so reports are only submitted when VHF signals readiness. Continuous state updates now coalesce to the latest value while discrete button, D-pad, trigger-threshold, report-ID, and touch-contact transitions stay ordered, and Switch protocol replies are prioritized to keep the handshake responsive. Also document the buffering policy and add unit coverage for queue behavior across supported Windows gamepad profiles.
@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.84946% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.11%. Comparing base (0400b79) to head (0d77756).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...platform/windows/shared/vhf_input_report_queue.hpp 97.84% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   74.76%   75.11%   +0.35%     
==========================================
  Files          33       34       +1     
  Lines        7957     8050      +93     
  Branches     2982     3012      +30     
==========================================
+ Hits         5949     6047      +98     
+ Misses       1731     1725       -6     
- Partials      277      278       +1     
Flag Coverage Δ
FreeBSD 51.65% <87.01%> (+0.63%) ⬆️
Linux-Clang 57.14% <90.90%> (+0.50%) ⬆️
Linux-GCC 67.88% <92.10%> (+0.36%) ⬆️
Windows-MSVC 88.24% <98.61%> (+0.33%) ⬆️
Windows-MinGW-UCRT64 64.78% <92.10%> (+0.42%) ⬆️
macOS 51.01% <87.01%> (+0.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...platform/windows/shared/vhf_input_report_queue.hpp 97.84% <97.84%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0400b79...0d77756. Read the comment docs.

@sonarqubecloud

Copy link
Copy Markdown

@ReenigneArcher
ReenigneArcher marked this pull request as ready for review August 15, 2026 14:06
@ReenigneArcher
ReenigneArcher merged commit dcc7e92 into master Aug 15, 2026
31 checks passed
@ReenigneArcher
ReenigneArcher deleted the fix/windows/latency-improvements branch August 15, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant