chore(composer): widen dependency ranges and alias master as 2.0-dev#76
Merged
Merged
Conversation
v1.4.1 narrowed the requirements to PHP >= 8.4 and API Platform ^4.2 in a patch release. Restore wide ranges: PHP ^8.2, api-platform/symfony ^3.4 || ^4.0, doctrine/orm ^3.0, doctrine-bundle ^2.13 || ^3.0, and real version ranges for the symfony/* packages instead of wildcards. Alias dev-master as 2.0-dev: the next release is v2.0.0. Remove the conflict rule against symfony/translations-contracts: the package name is misspelled (the real package is symfony/translation-contracts) so it never had any effect, and the new symfony/translation floor makes it redundant. Expand CI to the supported PHP range (8.2 to 8.5) plus a lowest-deps leg, and drop the vestigial .env.test and sqlite steps: the suite is pure unit tests and needs neither.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
v1.4.1 narrowed the requirements to PHP >= 8.4 and API Platform ^4.2 in a patch release, stranding API Platform 3 and PHP 8.2/8.3 users on v1.4 although nothing in the code requires the newer platforms. The symfony/* constraints were unbound wildcards, the branch alias still said 1.0-dev, and the conflict rule targeted a misspelled package name (
symfony/translations-contracts), so it never had any effect.Changes
php ^8.2,api-platform/symfony ^3.4 || ^4.0,doctrine/orm ^3.0,doctrine/doctrine-bundle ^2.13 || ^3.0, and real ranges (^6.4 || ^7.0 || ^8.0) forsymfony/translationandsymfony/dependency-injectioninstead of*.dev-masteras2.0-dev: the next release will be tagged v2.0.0.conflictentry (misspelled package name, and the new symfony/translation floor makes it redundant anyway).composer validate --strict, and drop the vestigial.env.test/sqlite steps (the suite is pure unit tests and needs neither).Verification
Locally on PHP 8.4:
composer update --prefer-lowest --prefer-stableresolves to api-platform/symfony 3.4.0, symfony 6.4, doctrine/orm 3.0.0, doctrine-bundle 2.13.0 and the suite passes 45/45; highest deps resolve to api-platform/symfony 4.3.15, symfony 8.1.1, orm 3.6.7, doctrine-bundle 3.2.4, also 45/45.composer validate --strictis clean.