Skip to content

fix(components): isolate onboarding tour cloud access [risk:medium] - #136

Merged
Leeeon233 merged 1 commit into
mainfrom
fix/electron-onboarding-cloud-isolation
Aug 28, 2026
Merged

fix(components): isolate onboarding tour cloud access [risk:medium]#136
Leeeon233 merged 1 commit into
mainfrom
fix/electron-onboarding-cloud-isolation

Conversation

@Leeeon233

Copy link
Copy Markdown
Contributor

Risk: 🟡 medium | Confidence: high — isolates the Electron onboarding tour from the outer authenticated cloud adapter; provider wiring and escape paths are covered by regression tests

Summary

  • wrap the production-component onboarding tour in an isolated platform and authenticated cloud boundary
  • serve tour machine and local-project fixtures locally while rejecting writes and containing unknown reads
  • add wiring-level regression coverage so the tour cannot query the real backend again

Verification

  • pnpm check:affected
  • components typecheck
  • onboarding isolation tests: 17 passed
  • adversarial client and scope review completed

@github-actions github-actions Bot added scope: components status:pr-too-large External PR over 200 changed lines needs a prior issue within seven days labels Aug 28, 2026
@github-actions

Copy link
Copy Markdown

@Leeeon233, this pull request changes 467 lines (additions + deletions) without linking a prior Lody issue.

It is marked status:pr-too-large. The PR-body policy gives you seven days from the first invalid-body notice to fix the description. Open an issue, wait for maintainers to explicitly agree on the scope and approach, then add its full URL to ## Related issue. Creating an issue yourself is not approval.

The size warning clears automatically after a valid Issue URL is linked. If the PR body remains invalid for seven days, the shared expiry policy closes the PR and requires a new submission; automation verifies the URL but maintainers decide whether prior agreement is sufficient.

@github-actions

Copy link
Copy Markdown

@Leeeon233, this pull request body does not match Lody's PR template.

This PR is marked status:needs-pr-body. Update the description and satisfy every required section by 2026-09-04 13:40:46 UTC. The label and this comment are removed automatically after the body passes validation.

If the body remains invalid for 7 days, this PR will be closed and marked status:pr-body-expired. To contribute after that, open a new pull request using the current template.

Every external PR must link a Lody issue and provide a complete public Context handoff with concise, PR-specific review instructions. N/A and redacted context are not accepted because maintainers need enough provenance, scope, and risk information to assess the contribution.

Checker findings
PR body does not match the Lody pull request template:

- Missing required heading: ## Related issue
- Missing required heading: ## Problem / pressure
- Missing required heading: ## Test plan
- Missing required heading: ## Context handoff
- Context handoff must include ### Instructions for reviewing agents.
- Context handoff must include ### Authoring context.
- Context handoff must keep <!-- context-handoff:begin/end --> markers.

See `.github/PULL_REQUEST_TEMPLATE.md`.

@github-actions github-actions Bot added the status:needs-pr-body PR body does not meet the contribution template label Aug 28, 2026
@Leeeon233
Leeeon233 merged commit b9dcace into main Aug 28, 2026
4 of 5 checks passed
@Leeeon233
Leeeon233 deleted the fix/electron-onboarding-cloud-isolation branch August 28, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:medium scope: components status:needs-pr-body PR body does not meet the contribution template status:pr-too-large External PR over 200 changed lines needs a prior issue within seven days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant