fix(components): stop sidebar resize chat jitter - #371
Merged
Conversation
Ignore width-only viewport ResizeObserver records so the Virtua adapter does not compete with the content bottom observer during sidebar animation. Keep height-driven re-anchoring for keyboard and dock changes, and cover the width-only path with a regression test. Model: gpt-5.6-sol
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Same-repository fix; no tracking issue was required for intake.
Problem / pressure
Opening or closing the desktop navigation sidebar animates the conversation viewport width. The sticky-scroll viewport observer treated every width-only ResizeObserver record as a reason to re-anchor Virtua at the bottom, competing with
use-stick-to-bottomand making the conversation move vertically by a few pixels.Summary
Before / after
Test plan
pnpm exec vitest run tests/use-sticky-scroll.test.tsfrompackages/components: 7 tests passed.pnpm typecheckfrompackages/components: passed.pnpm exec prettier --check src/hooks/use-sticky-scroll.ts tests/use-sticky-scroll.test.ts src/hooks/AGENTS.md: passed.git diff --check: passed.Context handoff
Instructions for reviewing agents
use-sticky-scroll.tsand the repeated width-resize regression inuse-sticky-scroll.test.ts.use-stick-to-bottomwhile the app adapter owns only viewport height re-anchoring.Authoring context