fix(site-docs): brand docs, blog, changelog, and pricing titles with | Lody - #379
Merged
Conversation
Append the Lody brand to docs, blog, changelog, and pricing document titles without double-branding landing pages that already include it. Model: cursor-grok-4.6 Co-authored-by: Zixuan Chen <zx@loro.dev>
zxch3n
marked this pull request as ready for review
September 4, 2026 05:37
Model: cursor-grok-4.6 Co-authored-by: Zixuan Chen <zx@loro.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / pressure
Public docs, blog, changelog, and pricing tab titles on lody.ai were bare page names (
Introduction,Blog,Pricing). Search results and browser tabs did not identify Lody. The metadata fallback description was the weak stringLody AI. Landing titles already include the brand and must not be double-suffixed.Summary
brandTitle()insite-docs/lib/metadata.ts. Empty titles becomeLody. Titles that already contain the brand, or already end with| Lody/– Lody/- Lody, stay as-is. Everything else becomes${title} | Lody.brandTitleonly to docs, blog, changelog, and pricinghead()titles. VisibleDocsTitlestays unbranded. Landing and download heads are unchanged.pageHeaddescription fallback with the product sentence used on the homepage.site-docs/AGENTS.mdand coverbrandTitleplus the description fallback with a Node test. The testtest()calls are awaited so type-aware oxlintno-floating-promisesstays clean.Before / after
/docs/document titleIntroductionIntroduction | LodyLody - Run your agents in parallel, safelyLody AITest plan
corepack pnpm --filter @lody/site-docs test— postinstall tests plusbrandTitle/pageHeadfallback tests passed (7/7).brandTitle('Introduction')isIntroduction | Lody;landingPageTitle('en')staysLody - Run your agents in parallel, safely.corepack pnpm lint(type-aware oxlint) — 0 errors after awaiting thenode:testregistrations. First CI run failed on those four floating promises.DocsTitlestill rendersdata.titlewithout the brand suffix.landing.tsx/download.tsxstill pass their existing titles throughpageHeadwithoutbrandTitle.@lody/site-docstscfailed on missingacp-extension-core/acp-extension-dshsubmodule types in@lody/shared. That is an environment checkout gap, not a title-helper error.Context handoff
Instructions for reviewing agents
site-docs/lib/metadata.tsbrandTitleand the fivehead()call sites insrc/site-pages/{docs,blog,changelog,pricing}.tsx.pageHead, so landing/download/legal titles stay author-controlled.| Lodyappended; that is intentional. Legal pages were left unbranded because they were out of scope.Authoring context
Title | Lodywithout double-branding the homepage.site-docs/. Do not change visibleDocsTitle. Leave landing and download heads alone.brandTitletreats any case-insensitive occurrence of the brand as already branded, so titles likeDownload Lodyare not suffixed.tscwas blocked by missing ACP extension submodule types in this environment.