Skip to content

fix: keep fork actions visible while loading - #578

Merged
wibus-wee merged 1 commit into
mainfrom
feat/fork-loading-group
Sep 10, 2026
Merged

fix: keep fork actions visible while loading#578
wibus-wee merged 1 commit into
mainfrom
feat/fork-loading-group

Conversation

@wibus-wee

Copy link
Copy Markdown
Member

Related issue

Internal same-repository contribution; no Issue created solely for intake.

Problem / pressure

On desktop, assistant-turn actions are normally revealed by hover or keyboard focus. Starting a conversation fork replaces the Fork icon with a loading spinner, but moving the pointer away hid the entire action row and removed the visible progress signal.

Summary

  • Keep the existing assistant-turn action row visible while its fork is pending.
  • Cover the non-hover loading state with a DOM regression test.
  • Add a focused Storybook state for the pending fork UI.

Visual explanation

Simple change: one existing visibility condition now also accepts the already-propagated fork loading flag; a diagram would not add review value.

Before / after

Before After
Moving the pointer away during a fork hid the action row. The full action row remains visible until the fork leaves its loading state, then returns to normal hover and focus behavior.

Test plan

  • PATH=/opt/homebrew/opt/node@22/bin:$PATH pnpm check (all component and CLI suites passed; the Electron suite passed after restoring its locally missing binary)
  • PATH=/opt/homebrew/opt/node@22/bin:$PATH pnpm --filter @lody/electron test
  • PATH=/opt/homebrew/opt/node@22/bin:$PATH pnpm exec vitest run tests/assistant-turn-action-inset.test.ts from packages/components
  • PATH=/opt/homebrew/opt/node@22/bin:$PATH pnpm --filter @lody/components typecheck
  • pnpm run docs check

Context handoff

Instructions for reviewing agents

  • Review focus: Check AssistantTurnFooter visibility classes and the desktop pending-fork regression test.
  • Decisions to challenge: Confirm that the entire action row, rather than only the spinner, should remain visible while forking.
  • Plausible failures / evidence gaps: Automated coverage verifies rendered classes and controls; direct pointer interaction was not captured because browser-control tooling was unavailable.

Authoring context

  • User goal / directives: Keep the conversation Fork loading state visible after the pointer leaves and open this same-repository change as a ready-for-review PR.
  • Constraints / non-goals: Preserve normal desktop hover and focus behavior outside the loading state and leave mobile behavior unchanged.
  • Risk-bearing decisions: Reuse the existing per-message isForking state at the footer visibility boundary without changing fork lifecycle or protocol code.
  • Destructive or irreversible behavior: None; the change only affects presentation and adds deterministic test and story coverage.
  • Deliberately not done or tested: No live fork was created against user data; behavior is covered with DOM state and the focused Storybook fixture.
  • Unknowns / confidence: Low residual risk; the state is already propagated to the exact footer and the regression asserts the non-hover pending case.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-10T06:47:29.336715Z bc483f5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@wibus-wee
wibus-wee merged commit bfe13c4 into main Sep 10, 2026
6 checks passed
@wibus-wee
wibus-wee deleted the feat/fork-loading-group branch September 10, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant