refactor: extract the Tail Follow Engine into Core - #669
Merged
Conversation
Pulls the tail-event queue and worker out of LogWindow into LogExpert.Core.Classes.Tail.TailFollowEngine, behind an ITailFollowSink implemented by the Log Window (grid update, trigger scan, time spread stay behind the sink). The engine owns the dispatch policies, each pinned by a headless test: in-order delivery, rollover shift before content, the #634 never-die guard, abandoned-sink exit, and the bounded teardown join. The engine does not own the reader subscription - the Log Window swaps its Logfile Reader on load/reload/rollover and keeps forwarding FileSizeChanged into Post(). Resolves wayfinder ticket 04; glossary entries added to CONTEXT.md.
Inlines the one-line StopLogEventWorkerThread wrapper (banned name per the new CONTEXT.md entry, pure middle man), removes the stale worker field comment, and documents the engine ctor and Dispose, including why the Log Window deliberately calls only Stop() at close.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls the tail-event queue and worker out of LogWindow into LogExpert.Core.Classes.Tail.TailFollowEngine behind an ITailFollowSink implemented by the Log Window — rendering, trigger scan, and time spread stay in the UI. The engine owns the dispatch policies, each pinned by a headless test: in-order delivery, rollover shift before content, the #634 never-die guard, abandoned-sink exit, bounded teardown. Behavior-preserving: three original quirks are pinned rather than fixed, and the engine does not own the reader subscription (the Log Window swaps readers on reload/rollover; watcher ownership is re-decided with the LogfileReader decomposition). The tailing behavior of the log tailer is now verified — the last big untested engine has left the Log Window.