fix: add language switcher to login screen - #18
Merged
Conversation
Closes Logarex#16 The language selector was previously only accessible in Settings, which requires a logged-in session. Users can now switch language directly on the login screen, before authenticating or entering local mode. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
Tested on Expo Go. Works as expected. |
Logarex
self-requested a review
May 18, 2026 05:16
Owner
|
Awesome work, thanks again! I tested it locally and it works perfectly. Since this PR was likely branched before the German translation PR was merged, the "Deutsch" option is missing from the SegmentedControl on the login screen. I'm going to merge this PR right now and I will push a quick follow-up commit to add the German option to the login screen picker so it matches the settings screen. Thanks for fixing this issue so quickly! |
Logarex
added a commit
that referenced
this pull request
Jun 25, 2026
fix: add language switcher to login screen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16
Problem
The language selector was only available in Settings, which requires an active session. Users who wanted to change the language before logging in (or entering local mode) had no way to do so.
Solution
A
SegmentedControllanguage picker is now shown at the bottom of the login screen, identical in behaviour to the one in Settings. It uses the sameusePreferenceshook and persists the selection viaAsyncStorage— so the chosen language is remembered across sessions.Note
I have not been able to test this on a real device yet — that will happen over the next few days. The implementation was generated with Claude Code.