feat: render standard event fields first - #3368
Merged
Ziinc merged 3 commits intoApr 24, 2026
Merged
Conversation
msmithstubbs
force-pushed
the
feat/json-viewer-promoted-fields
branch
2 times, most recently
from
April 16, 2026 00:30
66c3904 to
351dbf3
Compare
msmithstubbs
commented
Apr 16, 2026
| :timer.sleep(2500) | ||
|
|
||
| assert_receive {:insert_all, [%{json: %{"attributes" => _}} | _] = rows}, 5_000 | ||
| assert_receive {:insert_all, [%{json: %{"attributes" => _}} | _] = rows}, 15_000 |
Contributor
Author
There was a problem hiding this comment.
Not part of this feature but CI kept failing.
Contributor
There was a problem hiding this comment.
@nelsonmestevao can you investigate this? We should also convert the sleep into a retry
Contributor
There was a problem hiding this comment.
I am not sure how to change this. I could not make this test pass reliable with a smaller assert receive time. However, I could at least remove the sleep in this PR.
I will investigate how ingest_logs could be more reliable for the tests. I believe we had some similar issue that I worked with @laraujo7.
msmithstubbs
marked this pull request as ready for review
April 16, 2026 03:43
msmithstubbs
force-pushed
the
feat/json-viewer-promoted-fields
branch
from
April 19, 2026 23:22
c9d61a3 to
6b68c22
Compare
Ziinc
approved these changes
Apr 22, 2026
Ziinc
requested changes
Apr 22, 2026
Contributor
|
Seems really overly complex for sorting of keys |
msmithstubbs
marked this pull request as draft
April 22, 2026 06:34
msmithstubbs
force-pushed
the
feat/json-viewer-promoted-fields
branch
from
April 23, 2026 07:03
6b68c22 to
80c1c0f
Compare
msmithstubbs
force-pushed
the
feat/json-viewer-promoted-fields
branch
from
April 23, 2026 07:06
80c1c0f to
476d9a5
Compare
msmithstubbs
marked this pull request as ready for review
April 24, 2026 03:43
Ziinc
approved these changes
Apr 24, 2026
djwhitt
pushed a commit
that referenced
this pull request
May 18, 2026
* feat: JSONViewer renders promoted fields first * ui: id quick_filter always visible * test: increase timeout to try and pass ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON viewer will render promoted fields (
id,timestamp,event_message) first.Closes O11Y-1596