feat: wire map2loop and loopstructural_visualisation into the workspace - #303
Open
lachlangrose wants to merge 1 commit into
Open
feat: wire map2loop and loopstructural_visualisation into the workspace#303lachlangrose wants to merge 1 commit into
lachlangrose wants to merge 1 commit into
Conversation
Completes Stage 4 (ROADMAP.md, outcomes 5/7) for map2loop and
loopstructural-visualisation, following on from the two ported packages
already merged in from agent worktrees (packages/map2loop,
packages/loopstructural_visualisation).
- Add both to [tool.uv.sources]; loopstructural_visualisation also needs
LoopStructural = { workspace = true } since it depends on LoopStructural
itself, which uv treats as an implicit workspace member once referenced
by name.
- CI: loopstructural_visualisation joins the existing packages-test matrix;
map2loop gets its own ubuntu-only job (map2loop-test) with an
apt-installed libgdal, since GDAL has no pip wheel on Windows/macOS and
upstream map2loop itself only tests via conda for the same reason.
- Add a minimal import-smoke test for loopstructural_visualisation, which
shipped with zero test coverage upstream.
- Wire both into pypi.yml sdist/publish, release-please-config.json +
.release-please-manifest.json (loopstructural_visualisation uses
extra-files to bump version.py's __version__, since it has no static
pyproject version field), and grandfather D/ANN ruff rules for both
(matching the loop_common/loop_interpolation precedent).
- Correct ROADMAP.md: loopresources (Stage 4a) was never actually merged
to master, despite a prior status-log entry claiming otherwise.
Verified: uv sync resolves cleanly for both packages standalone and as a
full workspace sync; tests/unit 695 passed/4 skipped (zero regressions).
(cherry picked from commit ce71cae)
This was referenced Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #298 / #299. PR 4 of 9 in the stack — depends on #302, which depends on #301 and #300.
Wires the two new packages (added in #301, #302) into the root workspace: updates
pyproject.toml,.github/workflows/packages.ymlandpypi.yml,release-please-config.json/ manifest,uv.lock, and adds a package import smoke test. This is the last PR in the "add map2loop + visualisation" line of the stack.