Support enacting manual loop if loop error #1252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellhenke
pushed a commit
to mitchellhenke/Loop
that referenced
this pull request
Apr 12, 2020
mitchellhenke
pushed a commit
to mitchellhenke/Loop
that referenced
this pull request
Apr 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tapping on the loop completion HUD view in the case of an error, a 'Retry' button allows the user to manually reattempt a loop.
This behavior is valuable when the reason for loop failure is expected to have been resolved, e.g. the user unsuspends their pump or power cycles their RileyLink in the case of comms failure. The user can now assert that their action did in fact resolve the problem, rather than waiting five minutes.