Skip to content

Support enacting manual loop if loop error #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 29, 2020
Merged

Support enacting manual loop if loop error #1252

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions Loop/View Controllers/StatusTableViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1258,13 +1258,23 @@ final class StatusTableViewController: ChartsTableViewController {
}

@objc private func showLastError(_: Any) {
var error: Error? = nil
// First, check whether we have a device error after the most recent completion date
if let deviceError = deviceManager.lastError,
deviceError.date > (hudView?.loopCompletionHUD.lastLoopCompleted ?? .distantPast)
{
self.present(UIAlertController(with: deviceError.error), animated: true)
error = deviceError.error
} else if let lastLoopError = lastLoopError {
self.present(UIAlertController(with: lastLoopError), animated: true)
error = lastLoopError
}

if error != nil {
let alertController = UIAlertController(with: error!)
let manualLoopAction = UIAlertAction(title: NSLocalizedString("Retry", comment: "The button text for attempting a manual loop"), style: .default, handler: { _ in
self.deviceManager.loopManager.loop()
})
alertController.addAction(manualLoopAction)
present(alertController, animated: true)
}
}

Expand Down