[protocol 3.6] Remove short storageID uses #1727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yueawang
approved these changes
Sep 14, 2020
| const sizeA = 25; | ||
| const sizeB = 43; | ||
| assert.equal(sizeA + sizeB, size, "invalid transform sizes"); | ||
| const size1 = 29; |
Contributor
There was a problem hiding this comment.
Per my understandings, TX_DATA_AVAILABILITY_SIZE(68) is the max bytes of DA in all types, what's the reason of this 29+39(before 25+43)? I think it is a separation best fits for 1 specific type (transfer??), is it?
Contributor
Author
There was a problem hiding this comment.
Yep, it's the number of bytes necessary for a trade. And transfers are normally a couple of bytes less so it works well for transfers as well (though if extra addresses are put onchain a transfer can actually make use of almost all 68 bytes, but that should be uncommon).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Loopring/team/issues/124
Numbers in the design doc updated for the worst case scenario where all bytes are non-zero (like we do for all other data as well), cost will be lower in practice.