Refactor and extend TR types#547
Merged
lahm86 merged 17 commits intoLostArtefacts:masterfrom Sep 18, 2023
Merged
Conversation
rr-
approved these changes
Sep 17, 2023
lahm86
added a commit
to lahm86/TR-Rando
that referenced
this pull request
Feb 12, 2024
Resolves LostArtefacts#605. Regression from LostArtefacts#547.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main goal here is to get a step ahead of the next round of IO refactoring. The plan there is to have things such as models, entities and static meshes linked directly to type enums rather than using just numbers. This will eventually shift the specifics to the IO - so for example,
TR2EntityhasTypeIDas ashortbutTRModelhas it as auint- these will becomeTR2Typein both cases and the necessary casting handled during IO instead of repeatedly throughout the solution.Sorry this is another big one. It may be best going through commit-by-commit - here is a summary of the changes:
TRLevelControl.Modelto avoidusingbloat everywhereTRXEntitiestoTRXType- this makes the difference clear betweenTRXEntityand its type