Refactor entity IO, storage and handling#548
Merged
lahm86 merged 24 commits intoLostArtefacts:masterfrom Sep 22, 2023
Merged
Conversation
rr-
approved these changes
Sep 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on from #547, this is quite a big cleanup for entity IO, storage and handling across all levels. Similar to before, this is generally broken down per commit.
TREntitytoTR1Entity.TR3EntityandTR5Entityto separate out from TR2/4 for these games.TREntityclass with genericTypeID.TR1Type,TR2Typeetc; removed unnecessary casting throughout.NumEntities.NumEntitieson the level.I've also simplified the logic for testing for enemy item drops to use LINQ and removed lots of duplication. And chicken behaviour conditions are also slightly more simplified, or at least more readable.
Part of #507 and part of #468.