sd: generation progress fixes - #2391
Open
wbruna wants to merge 2 commits into
Open
Conversation
Author
|
|
wbruna
force-pushed
the
kcpp_sd_preview_fixes
branch
from
August 9, 2026 03:01
2e16c4d to
da9e8ee
Compare
The preview callback is not called if preview images are not enabled, so when a preview image wasn't requested, the step count wouldn't be updated. So move the update to the progress callback. Additionally, adjust the total step count when the progress call reports a lower total (e.g. for img2img). Also remove the preview reset from inside the callback, since it often caused a preview miss, depending on when the next preview request arrived.
The progress callback is also called for VAE encoding and decoding, receiving the number of tiles as step count, so there is no simple way to detect the diffusion beginning. So we set up the first preview callback to detect it, and transition to the decoding phase when we reach the last step.
wbruna
force-pushed
the
kcpp_sd_preview_fixes
branch
from
August 10, 2026 21:48
da9e8ee to
4d43ce0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The preview callback is not called if preview images are not enabled, so when a preview image wasn't requested, the step count wouldn't be updated. So move the update to the progress callback. Additionally, adjust the total step count when the progress call reports a lower total (e.g. for img2img).
Also remove the preview reset from inside the callback, since it often caused a preview miss, depending on when the next preview request arrived.