Fold bank statement import into the README - #16
Merged
Conversation
The README was last expanded in #14, before the statement import feature landed in #15, so it had no mention of the importer at all. - New "Importing a bank statement" feature section - New "Decision: statement import keeps raw data off the server" section covering the privacy boundary, the client-side fingerprint, and the partial unique index - merchant_rules and expenses.source_fingerprint in the data model table - import_expenses() in the RPC list - computeSplits() now noted as shared by three call sites, not two - features/import/, core/dates.dart, docs/statement-import.md in the tree - test count 58 -> 165, plus the import test group - test.yml documented; dropped the stale "tests in CI" gap and added "PDF statement import" to the roadmap - removed no em dashes (there were none); kept the existing voice Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PcEjJSFabfyzty3uUXx6dQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README was last expanded in #14, which landed just before the bank statement import feature in #15, so it currently doesn't mention the importer anywhere.
Changes
merchant_rulesandexpenses.source_fingerprint.import_expenses().computeSplits()now noted as shared by three call sites (expense form, recurring form, import plan).features/import/,core/dates.dart,docs/statement-import.md.test/features/import/group and the fingerprint vector note.test.yml; removed the now-stale "tests in CI" item from Not built yet and added "PDF statement import".No em dashes were present and none were added; existing voice and structure preserved.
🤖 Generated with Claude Code