Skip to content

Conversation

@jmfayard
Copy link
Collaborator

@jmfayard jmfayard commented Apr 22, 2021

Hello @LouisCAD

I have upgraded this projec's dependencies

I also cleaned up the tests so that all the tests that we expect to be failing are in a file called FailingXXXX.kt

@jmfayard jmfayard requested a review from LouisCAD April 22, 2021 11:24
@jmfayard jmfayard removed the request for review from LouisCAD April 30, 2021 19:48
@jmfayard jmfayard merged commit d2ee867 into main Apr 30, 2021
@LouisCAD LouisCAD deleted the update-dependencies branch May 1, 2021 09:30
@LouisCAD
Copy link
Owner

LouisCAD commented May 1, 2021

FYI, you added a dependency coming from a bintray repo, while bintray is being shutdown just today @jmfayard

@jmfayard
Copy link
Collaborator Author

jmfayard commented May 1, 2021

Good catch, I opened an issue
JetBrains/markdown#80

In the build scan, it's possible to see which dependencies come from jcenter or bintray, I will have a look.

@LouisCAD
Copy link
Owner

LouisCAD commented May 1, 2021

In that issue, you also talk about jcenter. If that library is on jcenter, please, replace the bintray repo with jcenter, which is still available in read-only, until it lands on MavenCentral.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants