⚡ Bolt: [performance improvement]

[Lucenx9]

• 💡 What: Refactored push_tab_to_leaf to take &str instead of String and deferred allocation.
• 🎯 Why: To avoid eager O(N) string allocations (.clone()) during recursive tree traversals.
• 📊 Impact: Eliminates unnecessary heap allocations when iterating through non-matching nodes in the pane tree, reducing memory overhead and improving performance.
• 🔬 Measurement: The change preserves existing test behavior and can be verified via cargo test.

---

PR created automatically by Jules for task 5668418464238161413 started by @Lucenx9

Summary

• Refactored push_tab_to_leaf to pass &str during recursive pane-tree traversal.
• Deferred String allocation until tab insertion.
• Reduced unnecessary cloning and heap allocation.
• Preserved existing behavior.

Impact

• No user-visible behavior changes.
• No native GTK/VTE changes.
• No socket changes.
• Core Rust code now uses borrowed surface IDs during traversal.

Tests

• Existing tests remain applicable.
• Verify with cargo test.

Security and privacy

• No security or privacy impact identified.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c715e2ff-e24a-4407-8fec-9c900264af17

📥 Commits

Reviewing files that changed from the base of the PR and between 5b45feb and 859c911.

📒 Files selected for processing (3)

• .jules/bolt.md
• crates/forktty-core/src/model.rs
• crates/forktty-core/src/model/pane_tree.rs

---

📝 Walkthrough

Walkthrough

The tab insertion path now passes the new tab ID as &str during recursive pane-tree traversal. It creates an owned SurfaceId only when inserting into a leaf. Documentation records this allocation guideline.

Changes

Tab ID allocation

Layer / File(s)	Summary
Borrowed tab insertion path crates/forktty-core/src/model/pane_tree.rs, crates/forktty-core/src/model.rs, .jules/bolt.md	push_tab_to_leaf forwards the tab ID by reference through recursive calls and converts it to an owned value at insertion. WorkspaceModel::add_tab passes the borrowed ID. The guideline documents this pattern.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

• Lucenx9/forktty#338: Makes the same borrowing changes in push_tab_to_leaf and WorkspaceModel::add_tab.
• Lucenx9/forktty#340: Applies the same deferred-allocation changes in the pane-tree insertion path.
• Lucenx9/forktty#383: Modifies the same traversal and caller to avoid tab ID cloning.

Suggested labels: rust, docs

🚥 Pre-merge checks | ✅ 6

✅ Passed checks (6 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the performance-focused refactoring and is concise.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Privacy Boundary	✅ Passed	The PR only changes in-memory tab-ID ownership and adds a local allocation note; it adds no telemetry, network calls, or terminal-output persistence.
Terminal Command Safety	✅ Passed	The patch only changes pane-tree string ownership and adds documentation; it introduces no PTY, socket, worktree, shell, packaging, notification, or command execution behavior.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch bolt-optimize-pane-tree-allocation-5668418464238161413

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 859c91110f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Remove the one-off root metadata directory

This recreates a .jules/ top-level bucket for a single automation note, even though nothing in the repository consumes it; a repo-wide search only finds the prior CHANGELOG entry documenting removal of a stale .jules/bolt.md. Drop this artifact or place any durable performance documentation near the owning model module instead of adding another root content category.

AGENTS.md reference: AGENTS.md:L131-L131

Useful? React with 👍 / 👎.