Skip to content

v2.4.3 — Hook tests isolated from PATH; both install routes documented

Choose a tag to compare

View all tags
@LuisFelipeMoro LuisFelipeMoro released this 31 Aug 21:20
· 80 commits to main since this release
v2.4.3
a63d607
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode.

The test bug, found by fixing something else

run_hook prepended the stub directory to the caller's PATH, leaving the real binaries reachable further down it. Every case asserting a tool is absent was therefore asserting something about the machine, not the hook. The suite was green for two releases — until jscpd was installed here, at which point nine assertions failed for reasons unrelated to the code under test.

Now scoped to <stubs>:/usr/bin:/bin. Verified both ways, which is the point: green with jscpd installed and with it hidden from PATH entirely; falsified by reverting to the caller's PATH, which reproduces the nine failures exactly.

Same defect class the suite's own header warns about — a gate passing for the wrong reason. It just happened to be in the tests rather than the hooks.

The double-loaded standards

install.sh imports ~/.claude/devkit/CLAUDE.md globally, so it applies everywhere. This repo also @-imported its own identical copy — ~6,560 tokens loaded twice per session, but only when working on the devkit itself. The repo file now points at the canonical path and tells an uninstalled contributor how to get it. No other repository was ever affected.

Both install routes, stated honestly

A plugin cannot write to .git/hooks/ and cannot ship a CLAUDE.md. Rather than pretend otherwise: the skills and agents restate inline the rules they depend on, so the plugin route works correctly standalone — verified, not assumed. What it does not carry is the repo-wide contract (Coding Discipline, Proportionality, Security Defaults, and the objectives that break ties), and the README now gives the three lines that add it. Both routes are supported; neither is going away.

Also

  • install.sh --dry-run printed npm install -gjscpd, missing its space — a copy-pasteable command. The real install path was always correct.
  • marketplace.json still advertised an 11-agent pipeline without the Plan Reviewer.

Plugin versions: coding-pipeline 2.4.3

Assets 2
Loading