Skip to content

fix: remove port requirement for supenrode from lumera#136

Merged
mateeullahmalik merged 1 commit intomasterfrom
fix/remove-port-from-blockchain
Aug 21, 2025
Merged

fix: remove port requirement for supenrode from lumera#136
mateeullahmalik merged 1 commit intomasterfrom
fix/remove-port-from-blockchain

Conversation

@mateeullahmalik
Copy link
Collaborator

No description provided.

@a-ok123 a-ok123 requested review from a-ok123 and Copilot August 21, 2025 21:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the port requirement for supernode registration in lumera by changing the registration API to only require an IP address, with the port being automatically appended using a default value.

  • Refactor supernode registration to use IP addresses instead of host:port combinations
  • Introduce a default supernode port constant (DefaultSupernodePort = "4444") for consistent port usage
  • Update test configurations to use loopback IP addresses with unified port settings

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/system/e2e_cascade_test.go Updates supernode registration test to pass IP addresses instead of ports
tests/system/config.test-*.yml Modifies test configurations to use loopback IPs and standardized ports
sdk/net/impl.go Implements automatic port appending to IP addresses from blockchain data
sdk/config/constants.go Adds new constant for default supernode port
p2p/kademlia/bootstrap.go Refactors IP parsing logic into a separate function

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mateeullahmalik mateeullahmalik merged commit 8d0f52f into master Aug 21, 2025
7 checks passed
@mateeullahmalik mateeullahmalik deleted the fix/remove-port-from-blockchain branch August 21, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants