fix: remove port requirement for supenrode from lumera#136
Merged
mateeullahmalik merged 1 commit intomasterfrom Aug 21, 2025
Merged
fix: remove port requirement for supenrode from lumera#136mateeullahmalik merged 1 commit intomasterfrom
mateeullahmalik merged 1 commit intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the port requirement for supernode registration in lumera by changing the registration API to only require an IP address, with the port being automatically appended using a default value.
- Refactor supernode registration to use IP addresses instead of host:port combinations
- Introduce a default supernode port constant (
DefaultSupernodePort = "4444") for consistent port usage - Update test configurations to use loopback IP addresses with unified port settings
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/system/e2e_cascade_test.go | Updates supernode registration test to pass IP addresses instead of ports |
| tests/system/config.test-*.yml | Modifies test configurations to use loopback IPs and standardized ports |
| sdk/net/impl.go | Implements automatic port appending to IP addresses from blockchain data |
| sdk/config/constants.go | Adds new constant for default supernode port |
| p2p/kademlia/bootstrap.go | Refactors IP parsing logic into a separate function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
a-ok123
approved these changes
Aug 21, 2025
mateeullahmalik
added a commit
that referenced
this pull request
Aug 22, 2025
mateeullahmalik
added a commit
that referenced
this pull request
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.