Skip to content

Revert "fix: remove port requirement for supernode from lumera (#136)#137

Merged
mateeullahmalik merged 1 commit intomasterfrom
rollbackPortRemoval
Aug 25, 2025
Merged

Revert "fix: remove port requirement for supernode from lumera (#136)#137
mateeullahmalik merged 1 commit intomasterfrom
rollbackPortRemoval

Conversation

@mateeullahmalik
Copy link
Collaborator

No description provided.

@a-ok123 a-ok123 requested review from a-ok123 and Copilot August 22, 2025 20:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts a previous change that removed the port requirement for supernodes from the Lumera protocol. The revert restores the requirement that supernodes must specify their port as part of their endpoint configuration.

  • Restores port requirement in supernode registration by modifying the test helper function to accept a port parameter
  • Updates configuration files to use specific ports and localhost binding instead of IP-only addressing
  • Removes the default port constant and associated logic that was previously added to handle port-less endpoints

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/system/e2e_cascade_test.go Updates supernode registration test to require port parameter and use localhost:port format
tests/system/config.test-1.yml Changes host from 127.0.0.1 to 0.0.0.0 for broader network binding
tests/system/config.test-2.yml Updates host binding and assigns unique port/gateway_port values
tests/system/config.test-3.yml Updates host binding and assigns unique port/gateway_port values
sdk/net/impl.go Removes default port appending logic and reverts to using endpoints as provided
sdk/config/constants.go Completely removes the file containing DefaultSupernodePort constant

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mateeullahmalik mateeullahmalik merged commit f2dafe8 into master Aug 25, 2025
7 checks passed
@mateeullahmalik mateeullahmalik deleted the rollbackPortRemoval branch September 5, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants