Revert "fix: remove port requirement for supernode from lumera (#136)#137
Merged
mateeullahmalik merged 1 commit intomasterfrom Aug 25, 2025
Merged
Revert "fix: remove port requirement for supernode from lumera (#136)#137mateeullahmalik merged 1 commit intomasterfrom
mateeullahmalik merged 1 commit intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts a previous change that removed the port requirement for supernodes from the Lumera protocol. The revert restores the requirement that supernodes must specify their port as part of their endpoint configuration.
- Restores port requirement in supernode registration by modifying the test helper function to accept a port parameter
- Updates configuration files to use specific ports and localhost binding instead of IP-only addressing
- Removes the default port constant and associated logic that was previously added to handle port-less endpoints
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/system/e2e_cascade_test.go | Updates supernode registration test to require port parameter and use localhost:port format |
| tests/system/config.test-1.yml | Changes host from 127.0.0.1 to 0.0.0.0 for broader network binding |
| tests/system/config.test-2.yml | Updates host binding and assigns unique port/gateway_port values |
| tests/system/config.test-3.yml | Updates host binding and assigns unique port/gateway_port values |
| sdk/net/impl.go | Removes default port appending logic and reverts to using endpoints as provided |
| sdk/config/constants.go | Completely removes the file containing DefaultSupernodePort constant |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
a-ok123
approved these changes
Aug 22, 2025
a-ok123
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.