Update event listener example #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrentinTheKid
approved these changes
Feb 6, 2024
vectrixdevelops
approved these changes
Feb 8, 2024
Merged
ItsNature
added a commit
that referenced
this pull request
May 30, 2024
* Publish as 1.1.0-SNAPSHOT * Fix - Add missing information on custom model data to docs (#121) * fix: add missing information on custom model data to docs * add note about durability * Update event listener example (#124) * Disable Packet Enrichment module by default (#123) * Default packet enrichment module to disabled * Add callout to packet enrichment module docs * Allow releases on version branches (#122) * Add Glint Module docs placeholder * Add glint module docs * docs(glint) - add hex example * Add showcase to overview * Center showcase --------- Co-authored-by: Connor <vectrixu+gh@gmail.com> Co-authored-by: TrentinTheKid <25537885+TrentinTheKid@users.noreply.github.com>
ItsNature
added a commit
that referenced
this pull request
May 31, 2024
* Deploy as 1.1.3-SNAPSHOT * Sync LunarClient Mods & Options (#146) * Sync LunarClient Mods & Options * Replace version since tags --------- Co-authored-by: LunarClient Bot <lc-bot@moonsworth.com> * Implement Notification icons with nanosvg support (#147) * Fix TNT Countdown Module on 1.20.5+ (#149) * Revert "Implement Notification icons with nanosvg support (#147)" This reverts commit 41bb888. * Feature - Glint Module (#150) * Publish as 1.1.0-SNAPSHOT * Fix - Add missing information on custom model data to docs (#121) * fix: add missing information on custom model data to docs * add note about durability * Update event listener example (#124) * Disable Packet Enrichment module by default (#123) * Default packet enrichment module to disabled * Add callout to packet enrichment module docs * Allow releases on version branches (#122) * Add Glint Module docs placeholder * Add glint module docs * docs(glint) - add hex example * Add showcase to overview * Center showcase --------- Co-authored-by: Connor <vectrixu+gh@gmail.com> Co-authored-by: TrentinTheKid <25537885+TrentinTheKid@users.noreply.github.com> * Add showcase image to module overviews (#151) * Attempt module showcase again * Remove br & hr * fix: format * Add more imgs * Add img for rich presence * center imgs * Update Colored Fire showcase * Update img --------- Co-authored-by: Sam <sam.sergi@outlook.com> * Sync LunarClient Mods & Options (#153) * Sync LunarClient Mods & Options * Update version since tags --------- Co-authored-by: LunarClient Bot <lc-bot@moonsworth.com> * Bump to 1.1.3 (#152) --------- Co-authored-by: LunarClient Bot <lc-bot@moonsworth.com> Co-authored-by: Connor <vectrixu+gh@gmail.com> Co-authored-by: TrentinTheKid <25537885+TrentinTheKid@users.noreply.github.com> Co-authored-by: Sam <sam.sergi@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Description:
Update the event listener example with a working example.
Changes:
We were incorrectly accessing the Bukkit's
Playerobject from theApolloPlayer.Review Request Checklist
feature/add-module&bugfix/fix-issue)