Skip to content

Conversation

@TrentinTheKid
Copy link
Member

Overview

Description:
Adds example images to the module overviews.

Preview on the dev page: https://62c5205f.lunarclient-dev.pages.dev/apollo/developers/modules/cooldown

@TrentinTheKid TrentinTheKid changed the title Docs/add assets Add showcase image to module overviews May 20, 2024
@colinmcdonald22
Copy link
Member

  • Colored fire: Can theimage be zoomed in more? A solid 50% of this image could just be cropped
  • Cooldowns: The caption and image reference SVGs -> I thought this PR was still a draft?
  • Team view: The caption references the minimap but there's no minimap in the image

All of the other images are perfect, glad we're finally adding these

@ItsNature ItsNature added the type: Documentation Documentation improvement or issue label May 21, 2024
@ItsNature ItsNature changed the base branch from master to version/1.1.3 May 21, 2024 12:48
@ItsNature ItsNature mentioned this pull request May 30, 2024
@ItsNature ItsNature merged commit 11ca7e1 into version/1.1.3 May 30, 2024
@ItsNature ItsNature deleted the docs/add-assets branch May 30, 2024 17:03
ItsNature added a commit that referenced this pull request May 31, 2024
* Deploy as 1.1.3-SNAPSHOT

* Sync LunarClient Mods & Options (#146)

* Sync LunarClient Mods & Options

* Replace version since tags

---------

Co-authored-by: LunarClient Bot <lc-bot@moonsworth.com>

* Implement Notification icons with nanosvg support (#147)

* Fix TNT Countdown Module on 1.20.5+ (#149)

* Revert "Implement Notification icons with nanosvg support (#147)"

This reverts commit 41bb888.

* Feature - Glint Module (#150)

* Publish as 1.1.0-SNAPSHOT

* Fix - Add missing information on custom model data to docs (#121)

* fix: add missing information on custom model data to docs

* add note about durability

* Update event listener example (#124)

* Disable Packet Enrichment module by default (#123)

* Default packet enrichment module to disabled

* Add callout to packet enrichment module docs

* Allow releases on version branches (#122)

* Add Glint Module docs placeholder

* Add glint module docs

* docs(glint) - add hex example

* Add showcase to overview

* Center showcase

---------

Co-authored-by: Connor <vectrixu+gh@gmail.com>
Co-authored-by: TrentinTheKid <25537885+TrentinTheKid@users.noreply.github.com>

* Add showcase image to module overviews (#151)

* Attempt module showcase again

* Remove br & hr

* fix: format

* Add more imgs

* Add img for rich presence

* center imgs

* Update Colored Fire showcase

* Update img

---------

Co-authored-by: Sam <sam.sergi@outlook.com>

* Sync LunarClient Mods & Options (#153)

* Sync LunarClient Mods & Options

* Update version since tags

---------

Co-authored-by: LunarClient Bot <lc-bot@moonsworth.com>

* Bump to 1.1.3 (#152)

---------

Co-authored-by: LunarClient Bot <lc-bot@moonsworth.com>
Co-authored-by: Connor <vectrixu+gh@gmail.com>
Co-authored-by: TrentinTheKid <25537885+TrentinTheKid@users.noreply.github.com>
Co-authored-by: Sam <sam.sergi@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: Documentation Documentation improvement or issue

Development

Successfully merging this pull request may close these issues.

5 participants