Replace "integer" types with "int", to suppress warnings in PHP 7.4 and PHP 8.0#5
Merged
jb-lopez merged 2 commits intoLupeCode:masterfrom Apr 11, 2021
Merged
Replace "integer" types with "int", to suppress warnings in PHP 7.4 and PHP 8.0#5jb-lopez merged 2 commits intoLupeCode:masterfrom
jb-lopez merged 2 commits intoLupeCode:masterfrom
Conversation
Contributor
|
Thanks @jackwh ! |
Contributor
Author
|
No problem 😊 On a side note, would you consider tagging a new release? The last one seems to be from 2016! This caught me out at first, I installed with |
Contributor
|
I had to manually update Packagist, but it looks okay now. Let me know if you cannot get 1.0.5 from composer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since PHP 7.4, the alias
integercan no longer be used as a scalar type. Instead,intmust be used. See here for some more info. When loading this package under PHP 8.0, this warning gets thrown in 12 separate places:This PR simply replaces the few instances of
integerwithint... and makes the errors go away.Thanks for a useful package!