Skip to content

Replace "integer" types with "int", to suppress warnings in PHP 7.4 and PHP 8.0 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jb-lopez merged 2 commits into from
Apr 11, 2021
Merged

Replace "integer" types with "int", to suppress warnings in PHP 7.4 and PHP 8.0 #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0491f1
Update TraderTrait to use correct scalar types
jackwh Apr 10, 2021
d81d9f0
Update Trader to use the correct scalar types
jackwh Apr 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions source/Trader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1504,7 +1504,7 @@ public static function exponentialMovingAverage(array $real, int $timePeriod): a
* @return int Returns the error code identified by one of the TRADER_ERR_* constants.
* @throws \Exception
*/
public static function errorNumber(): integer
public static function errorNumber(): int
{
return static::errno();
}
Expand Down Expand Up @@ -1547,7 +1547,7 @@ public static function mathFloor(array $real): array
* @return int Returns the compatibility mode id which can be identified by TRADER_COMPATIBILITY_* series of constants.
* @throws \Exception
*/
public static function getCompatibilityMode(): integer
public static function getCompatibilityMode(): int
{
return static::get_compat();
}
Expand All @@ -1562,7 +1562,7 @@ public static function getCompatibilityMode(): integer
* @return int Returns the unstable period factor for the corresponding function.
* @throws \Exception
*/
public static function getUnstablePeriod(integer $functionId): integer
public static function getUnstablePeriod(int $functionId): int
{
return static::get_unstable_period($functionId);
}
Expand Down Expand Up @@ -2242,7 +2242,7 @@ public static function parabolicSARExtended(array $high, array $low, float $star
*
* @throws \Exception
*/
public static function setCompatibilityMode(integer $compatId)
public static function setCompatibilityMode(int $compatId)
{
static::set_compat($compatId);
}
Expand All @@ -2256,7 +2256,7 @@ public static function setCompatibilityMode(integer $compatId)
*
* @throws \Exception
*/
public static function setUnstablePeriod(integer $functionId, int $timePeriod)
public static function setUnstablePeriod(int $functionId, int $timePeriod)
{
static::set_unstable_period($functionId, $timePeriod);
}
Expand Down
10 changes: 5 additions & 5 deletions source/TraderTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1776,7 +1776,7 @@ public static function ema(array $real, int $timePeriod = null): array
* @return int Returns the error code identified by one of the TRADER_ERR_* constants.
* @throws \Exception
*/
public static function errno(): integer
public static function errno(): int
{
$return = trader_errno();
static::checkForError();
Expand Down Expand Up @@ -1825,7 +1825,7 @@ public static function floor(array $real): array
* @return int Returns the compatibility mode id which can be identified by TRADER_COMPATIBILITY_* series of constants.
* @throws \Exception
*/
public static function get_compat(): integer
public static function get_compat(): int
{
$return = trader_get_compat();
static::checkForError();
Expand All @@ -1842,7 +1842,7 @@ public static function get_compat(): integer
* @return int Returns the unstable period factor for the corresponding function.
* @throws \Exception
*/
public static function get_unstable_period(integer $functionId): integer
public static function get_unstable_period(int $functionId): int
{
$return = trader_get_unstable_period($functionId);
static::checkForError();
Expand Down Expand Up @@ -2707,7 +2707,7 @@ public static function sarext(array $high, array $low, float $startValue = null,
*
* @throws \Exception
*/
public static function set_compat(integer $compatId)
public static function set_compat(int $compatId)
{
trader_set_compat($compatId);
static::checkForError();
Expand All @@ -2722,7 +2722,7 @@ public static function set_compat(integer $compatId)
*
* @throws \Exception
*/
public static function set_unstable_period(integer $functionId, int $timePeriod)
public static function set_unstable_period(int $functionId, int $timePeriod)
{
trader_set_unstable_period($functionId, $timePeriod);
static::checkForError();
Expand Down