Skip to content

fix-build: add compiler min version checks#677

Merged
howetuft merged 1 commit intoLuxCoreRender:for_v2.11from
JasonQiu1:add-compiler-version-check
Jul 16, 2025
Merged

fix-build: add compiler min version checks#677
howetuft merged 1 commit intoLuxCoreRender:for_v2.11from
JasonQiu1:add-compiler-version-check

Conversation

@JasonQiu1
Copy link
Copy Markdown
Contributor

Before luxcore builds, ensure minimum version for compiler is met:

  • gcc: >= 14
  • LLVM/Clang: >= 20
  • MSVC : >= 1940

Closes #676 and #675.

@howetuft
Copy link
Copy Markdown
Contributor

Hello,
Thank you very much! It looks really better to me: all platforms are addressed now and the plumbing of finding tool versions is delegated to Cmake, which provides on-the-shelf support for that!

One very important thing however (sorry, I was travelling yesterday and I missed this essential point): can you please target for_v2.11 rather than master?. v2.10 is frozen now (and master too). If needed, we will backport to for_v2.10.0. Thank you!

@JasonQiu1 JasonQiu1 changed the base branch from master to for_v2.11 July 16, 2025 04:36
@JasonQiu1
Copy link
Copy Markdown
Contributor Author

All good, I changed the base branch to for_v2.11!

@howetuft howetuft merged commit 479e15b into LuxCoreRender:for_v2.11 Jul 16, 2025
@howetuft
Copy link
Copy Markdown
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants