fix(release): keep source verification dependency-free#153
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c61bcf3324
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| function requireWorkflowStepText(step, expected, message, errors) { | ||
| if (!step.includes(expected)) errors.push(message); | ||
| } |
There was a problem hiding this comment.
Require exact continuity-gate step values
The new text-only check treats required YAML fields as arbitrary substrings, so it no longer verifies the values that protect the release gate. For example, changing the legacy or current proof command to run: pnpm … || true yields no consistency errors (despite allowing a failed compatibility proof to pass), and a checkout's required repository/ref text can be moved into a YAML comment while the actual value points elsewhere. The previous parsed-object comparisons rejected these cases; preserve exact field validation rather than accepting a textual occurrence.
Useful? React with 👍 / 👎.
Root cause
The protected release verifier runs before dependency installation by design, but the consistency script reintroduced a static
js-yamlimport. Main CI concealed the regression because its tooling lane installs workspace dependencies first. The v0.1.31 release therefore failed before any build or publication.Fix
Verification
pnpm checkpassesAfter this reaches current main, the existing immutable v0.1.31 tag can be repaired with the workflow_dispatch path.