Skip to content

perf: benchmark OMP Codex transports#49

Merged
wolfiesch merged 4 commits into
mainfrom
codex/omp-codex-transport-benchmark
Jul 18, 2026
Merged

perf: benchmark OMP Codex transports#49
wolfiesch merged 4 commits into
mainfrom
codex/omp-codex-transport-benchmark

Conversation

@wolfiesch

Copy link
Copy Markdown
Collaborator

Summary

  • add an alternating paired benchmark for OMP Codex WebSocket and SSE transports
  • capture redacted timing, token, tool-call, and transport diagnostics
  • document measured results and their proof boundaries
  • add focused tests for argument parsing, completion validation, aggregation, and secret-safe errors

Verification

  • pnpm check
  • pnpm test (1,469 tests passed)
  • node --test scripts/benchmark-omp-codex-transport.test.mjs
  • typos on the benchmark documentation, script, and tests
  • git diff --check

Copilot AI review requested due to automatic review settings July 18, 2026 13:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an OMP Codex transport benchmark harness (WebSocket vs SSE) to support measuring and reporting transport performance/diagnostics without handling credentials inside T4 Code, along with documentation and CI-integrated tests.

Changes:

  • Introduces a Node CLI harness to run paired/alternating OMP benchmark runs and produce a redacted JSON report (timings, tokens, tool-call counts, transport diagnostics).
  • Adds focused unit tests for argument parsing, prompt construction, event validation, aggregation, and secret-safe error reporting.
  • Documents measured results, reproduction steps, and the benchmark’s proof boundaries.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
scripts/benchmark-omp-codex-transport.mjs New benchmark harness + JSON parsing/aggregation and transport diagnostics collection.
scripts/benchmark-omp-codex-transport.test.mjs New unit tests covering parsing, validation, aggregation, and bounded error messaging.
package.json Wires the new benchmark test into the existing test:tooling suite.
docs/OMP_CODEX_TRANSPORT_BENCHMARK.md Documents methodology, results, reproduction steps, and proof boundary.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread scripts/benchmark-omp-codex-transport.mjs Outdated
Comment thread scripts/benchmark-omp-codex-transport.mjs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b5e54dbc9c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/benchmark-omp-codex-transport.mjs Outdated
Comment thread scripts/benchmark-omp-codex-transport.mjs Outdated
@wolfiesch
wolfiesch merged commit b5aea4d into main Jul 18, 2026
4 checks passed
@wolfiesch
wolfiesch deleted the codex/omp-codex-transport-benchmark branch July 18, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants