feat(release): sign and notarize macOS builds#63
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a protected, release-only macOS packaging path that signs with a pinned Developer ID identity, notarizes, staples, and then verifies both ZIP and DMG artifacts (while keeping the existing unsigned local packaging flow and deferring auto-updates).
Changes:
- Introduces a signed macOS packaging command (
pnpm package:mac) gated by environment/credentials, alongside the existing unsigned path. - Adds a macOS release identity contract plus an inspection script + tests, and wires the inspection into the release workflow to fail closed on signing/notarization/Gatekeeper drift.
- Updates release gate documentation and release-consistency checks to reflect and enforce the new macOS signing requirements.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| SECURITY.md | Documents the new macOS signing/notarization expectation starting at v0.1.24. |
| scripts/packaging.test.mjs | Extends packaging contract tests to assert signed macOS gating + workflow wiring. |
| scripts/package-mac-unsigned.mjs | Forces unsigned behavior via T4_MACOS_SIGNED_BUILD=0 for local builds. |
| scripts/package-mac-signed.mjs | Adds a credential-gated signed macOS packaging entrypoint. |
| scripts/inspect-macos-release.test.mjs | Adds tests for identity contract parsing and signature drift detection. |
| scripts/inspect-macos-release.mjs | Implements ZIP/DMG reopening + signature/Gatekeeper/stapler verification against a pinned identity. |
| scripts/check-release-consistency.mjs | Adds macOS identity contract checks and release gate text enforcement. |
| README.md | Documents the new maintainer-only pnpm package:mac command. |
| package.json | Adds package:mac and includes the new macOS inspection test in packaging tests. |
| electron-builder.config.mjs | Gates hardened runtime, notarization, and entitlements on T4_MACOS_SIGNED_BUILD. |
| docs/RELEASE_GATE.md | Adds macOS signing/notarization requirements to the release checklist. |
| docs/MACOS_SIGNING.md | Adds maintainer-facing documentation for signing/notarization and secret handling. |
| apps/desktop/build/entitlements.mac.plist | Adds macOS hardened-runtime entitlements used for signed builds. |
| .github/workflows/release.yml | Updates the protected release job to build signed macOS artifacts and verify identity/notarization before staging. |
| .github/macos-release-identity.json | Adds the pinned public macOS Developer ID identity contract. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
pnpm test:packagingpnpm checkpnpm test