Skip to content

Add line separation on the tag management table - #4530

Merged
ildyria merged 4 commits into
masterfrom
tag-lines-et-al
Jul 17, 2026
Merged

Add line separation on the tag management table#4530
ildyria merged 4 commits into
masterfrom
tag-lines-et-al

Conversation

@ildyria

@ildyria ildyria commented Jul 17, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Improved how selected values are displayed in various license, sorting, layout, ordering, and album settings menus, ensuring the correct localized label appears in the control itself (including when nothing is selected).
  • Localization
    • Updated admin dashboard NSFW configuration wording by removing per-trust “Block finding” action labels and adding clearer section grouping and action explanations.
  • Style
    • Refreshed tags table row divider styling for improved visual separation.

@ildyria
ildyria requested a review from a team as a code owner July 17, 2026 08:45
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cc93aa4e-2ec3-421e-b199-43240e73e680

📥 Commits

Reviewing files that changed from the base of the PR and between 3c46869 and 18476d9.

📒 Files selected for processing (23)
  • lang/ar/admin-dashboard.php
  • lang/bg/admin-dashboard.php
  • lang/cz/admin-dashboard.php
  • lang/de/admin-dashboard.php
  • lang/el/admin-dashboard.php
  • lang/en/admin-dashboard.php
  • lang/es/admin-dashboard.php
  • lang/fa/admin-dashboard.php
  • lang/fr/admin-dashboard.php
  • lang/hu/admin-dashboard.php
  • lang/it/admin-dashboard.php
  • lang/ja/admin-dashboard.php
  • lang/nl/admin-dashboard.php
  • lang/no/admin-dashboard.php
  • lang/pl/admin-dashboard.php
  • lang/pt/admin-dashboard.php
  • lang/ru/admin-dashboard.php
  • lang/sk/admin-dashboard.php
  • lang/sv/admin-dashboard.php
  • lang/tr/admin-dashboard.php
  • lang/vi/admin-dashboard.php
  • lang/zh_CN/admin-dashboard.php
  • lang/zh_TW/admin-dashboard.php
💤 Files with no reviewable changes (22)
  • lang/bg/admin-dashboard.php
  • lang/hu/admin-dashboard.php
  • lang/ar/admin-dashboard.php
  • lang/zh_TW/admin-dashboard.php
  • lang/sk/admin-dashboard.php
  • lang/cz/admin-dashboard.php
  • lang/es/admin-dashboard.php
  • lang/pt/admin-dashboard.php
  • lang/el/admin-dashboard.php
  • lang/it/admin-dashboard.php
  • lang/nl/admin-dashboard.php
  • lang/sv/admin-dashboard.php
  • lang/ja/admin-dashboard.php
  • lang/tr/admin-dashboard.php
  • lang/ru/admin-dashboard.php
  • lang/no/admin-dashboard.php
  • lang/de/admin-dashboard.php
  • lang/fr/admin-dashboard.php
  • lang/pl/admin-dashboard.php
  • lang/vi/admin-dashboard.php
  • lang/en/admin-dashboard.php
  • lang/zh_CN/admin-dashboard.php

📝 Walkthrough

Walkthrough

Changes

The PR adds translated selected-value rendering to USelectMenu controls across photo, album, settings, and bulk-edit interfaces. It also reorganizes NSFW dashboard translations across locales and adds row-divider classes to the tags table.

Localized select labels

Layer / File(s) Summary
Album and photo select rendering
resources/js/v8/components/drawers/PhotoEdit.vue, resources/js/v8/components/forms/album/AlbumProperties.vue, resources/js/v8/components/forms/photo/PhotoLicenseDialog.vue
Select menus use selectedLabel(modelValue) to render translated selected options while retaining item-label localization.
Bulk-edit select rendering
resources/js/v8/components/forms/bulk-album-edit/BulkEditFieldsDialog.vue, resources/js/v8/views/BulkAlbumEdit.vue
Bulk-edit enum and sorting menus render translated selected values through new helper functions.
Settings select rendering
resources/js/v8/components/forms/settings/SelectOptionsField.vue
The settings select menu translates its selected option through selectedLabel.

NSFW translation updates

Layer / File(s) Summary
Localized NSFW configuration copy
lang/*/admin-dashboard.php
NSFW translation maps remove trust-level-specific block labels and add or retain grouped action-section explanations across locales.

Tags table styling

Layer / File(s) Summary
Tags row dividers
resources/js/v8/views/TagsManagement.vue
The tags table body now uses divide-y divide-default classes.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Poem

I’m a bunny with labels, translated just right,
NSFW strings now hop in a tidier light.
Rows gain little dividers in tidy array,
Select menus sparkle—
Then I nibble hay!

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 36f7ee5e-22a0-4355-b821-4cbb3c5e51dd

📥 Commits

Reviewing files that changed from the base of the PR and between 83e06da and 3c46869.

📒 Files selected for processing (7)
  • resources/js/v8/components/drawers/PhotoEdit.vue
  • resources/js/v8/components/forms/album/AlbumProperties.vue
  • resources/js/v8/components/forms/bulk-album-edit/BulkEditFieldsDialog.vue
  • resources/js/v8/components/forms/photo/PhotoLicenseDialog.vue
  • resources/js/v8/components/forms/settings/SelectOptionsField.vue
  • resources/js/v8/views/BulkAlbumEdit.vue
  • resources/js/v8/views/TagsManagement.vue

Comment thread resources/js/v8/components/drawers/PhotoEdit.vue
@ildyria
ildyria merged commit 06d0cea into master Jul 17, 2026
49 checks passed
@ildyria
ildyria deleted the tag-lines-et-al branch July 17, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant