Skip to content

fix(tx): remove compat dev-dependency cycle — unblock publishability#73

Merged
Lythaeon merged 1 commit into
mainfrom
fix/tx-publish-cycle
Mar 27, 2026
Merged

fix(tx): remove compat dev-dependency cycle — unblock publishability#73
Lythaeon merged 1 commit into
mainfrom
fix/tx-publish-cycle

Conversation

@Lythaeon

Copy link
Copy Markdown
Owner

Description

Remove the unused sof-solana-compat dev-dependency from sof-tx.

This dependency created a publishability cycle for the 0.13.1 release:

  • sof-solana-compat depends on sof-tx
  • sof-tx had a dev-dependency on sof-solana-compat

That prevented either unpublished crate from passing cargo publish preparation first.

Changes

Detailed list of what changed:

  • crates/sof-tx/Cargo.toml: remove the unused sof-solana-compat dev-dependency.

For slice-related changes, include:

  • Affected slices: sof-tx packaging / release
  • Cross-slice communication changes: none
  • Migration requirements: none

Motivation

Business motivation:

  • Keep the repository aligned with what had to be published for 0.13.1.

Technical motivation:

  • Break the publish cycle between sof-tx and sof-solana-compat.
  • Make cargo publish preparation for both crates deterministic.

Alternative approaches considered:

  • Keep the cycle and manually patch releases ad hoc.
  • Publish from a dirty tree without fixing the repo state.

Scope and impact

  • Affected slices: sof-tx manifest only
  • Data/API changes: none
  • Backward compatibility: unchanged
  • Performance impact: none
  • Security impact: none

Testing

  • Unit tests
  • Integration tests
  • Manual verification
  • Performance checks (if applicable)
  • Security checks (if applicable)

Commands/results:

cargo check -p sof-tx -p sof-solana-compat --tests --examples
TMPDIR=$PWD/.tmp cargo publish -p sof-tx --locked
TMPDIR=$PWD/.tmp cargo publish -p sof-solana-compat --locked

All passed locally. sof-tx 0.13.1 and sof-solana-compat 0.13.1 were published successfully.

Related issues and documentation

Reviewer checklist

  • Code follows project standards and architecture constraints
  • Slice boundaries are respected (docs/architecture/ard/0003-slice-dependency-contracts.md)
  • Tests added/updated and passing
  • Documentation updated (README/docs/operations as needed)
  • No undocumented breaking change
  • Performance trade-offs documented where relevant
  • Security considerations addressed where relevant)

Additional notes

This manifest cleanup is intentionally minimal. It removes only the unused dev-dependency that blocked publishing.

@Lythaeon Lythaeon merged commit 6ea2a95 into main Mar 27, 2026
2 checks passed
@Lythaeon Lythaeon deleted the fix/tx-publish-cycle branch March 27, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant