Skip to content
This repository was archived by the owner on Sep 6, 2019. It is now read-only.

Fix for 'applications with only dangerous restricted are not half-ticked'#593

Merged
M66B merged 1 commit intoM66B:masterfrom
tonymanou:patch-1
Aug 27, 2013
Merged

Fix for 'applications with only dangerous restricted are not half-ticked'#593
M66B merged 1 commit intoM66B:masterfrom
tonymanou:patch-1

Conversation

@tonymanou
Copy link
Copy Markdown
Contributor

No description provided.

@tonymanou
Copy link
Copy Markdown
Contributor Author

It fixes issue #591 !

@LazyZhu
Copy link
Copy Markdown
Contributor

LazyZhu commented Aug 27, 2013

@tonymanou
Thanks for the fix.
Could you look into this #586 (comment) ?

@tonymanou
Copy link
Copy Markdown
Contributor Author

@LazyZhu
Yes that's it, this fix should correct the behavior you described in the other issue

@LazyZhu
Copy link
Copy Markdown
Contributor

LazyZhu commented Aug 27, 2013

@tonymanou

I mean another improvment :)

How about changing 'Filter on restricted' to 'Filter by restrict state' (three-states) just like 'Filter by application type'?

@tonymanou
Copy link
Copy Markdown
Contributor Author

@LazyZhu
Oh, sorry ^^' I though you only wanted to change the string for the filter.
That would be handy too, but we will need a four-state filter for that : no filter, half-ticked, full-ticked, all ticked.
I will take a look when I have some time

@LazyZhu
Copy link
Copy Markdown
Contributor

LazyZhu commented Aug 27, 2013

@tonymanou
What‘s difference between full-ticked and all ticked?

@tonymanou
Copy link
Copy Markdown
Contributor Author

@LazyZhu
full-ticked is a normal tick
all ticked would be full-ticked + half-ticked

@LazyZhu
Copy link
Copy Markdown
Contributor

LazyZhu commented Aug 27, 2013

@tonymanou
I see, looking forward to that :)

M66B added a commit that referenced this pull request Aug 27, 2013
Fix for applications with only dangerous restricted are not half-ticked
@M66B M66B merged commit 1bc5917 into M66B:master Aug 27, 2013
@M66B
Copy link
Copy Markdown
Owner

M66B commented Aug 27, 2013

Thanks, Tony, you are faster than me!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants