fix(oauth): send MCP-Protocol-Version on the executed authenticated r… - #3657
Conversation
…eplay The 2025-06-18 and 2025-11-25 debug OAuth machines previewed the MCP-Protocol-Version header on the post-token authenticated replay but omitted it from the request that actually went over the wire. The 2025-06-18 spec's Protocol Version Header section requires the header on all requests to the MCP server after initialization; 2026-07-28 already sent it on both. 2025-03-26 is deliberately untouched — that revision predates the header — and the new regression test locks in both the fix and the deliberate omission. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
WalkthroughOAuth authenticated MCP replay requests now include Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
sdk/src/oauth/state-machines/debug-oauth-2025-06-18.tsOops! Something went wrong! :( ESLint: 8.57.1 YAMLException: Cannot read config file: /sdk/eslint.config.mjs 7 | ...tseslint.configs.recommended, sdk/src/oauth/state-machines/debug-oauth-2025-11-25.tsOops! Something went wrong! :( ESLint: 8.57.1 YAMLException: Cannot read config file: /sdk/eslint.config.mjs 7 | ...tseslint.configs.recommended, sdk/tests/oauth/hardening-shared-pass.test.tsOops! Something went wrong! :( ESLint: 8.57.1 YAMLException: Cannot read config file: /sdk/eslint.config.mjs 7 | ...tseslint.configs.recommended, Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Internal previewPreview URL: https://mcp-inspector-pr-3657.up.railway.app |
…eplay
The 2025-06-18 and 2025-11-25 debug OAuth machines previewed the MCP-Protocol-Version header on the post-token authenticated replay but omitted it from the request that actually went over the wire. The 2025-06-18 spec's Protocol Version Header section requires the header on all requests to the MCP server after initialization; 2026-07-28 already sent it on both. 2025-03-26 is deliberately untouched — that revision predates the header — and the new regression test locks in both the fix and the deliberate omission.
Summary by cubic
Fixes missing
MCP-Protocol-Versionheader on the executed authenticated replay in OAuth debug flows. Aligns 2025-06-18 and 2025-11-25 machines with the spec and existing 2026-07-28 behavior.MCP-Protocol-Versionto replay requests indebug-oauth-2025-06-18.tsanddebug-oauth-2025-11-25.ts.@mcpjam/sdk.Written for commit 3a35062. Summary will update on new commits.