Bump fulmine to 5.5.0 - #1085
Conversation
|
C:/Program Files/Git/benchmark -f fulmine --save |
|
👋 |
|
Sorry, my shell rewrote the leading slash in the comment above into a Windows path. The command I meant: /benchmark -f fulmine --save |
|
👋 |
|
Pushed a second commit, so this PR is now the pin bump plus a change to the crud cache. Happy to split it if you would rather review them apart.
Two details that needed care:
The crud read path built its headers per request. Smoke tested in Docker against postgres 17 and redis 7 with the items table seeded: read MISS then HIT on the same connection, 404 for an id that is not there, list by category, POST upsert 201, and PUT followed by a read that comes back MISS with the new values, which is the invalidation doing its job. What I could not run here is |
Benchmark ResultsFramework:
Full log |
|
Thanks for running it. One row in that result is mine and it is a regression, so I have taken the change back.
The CPU is the interesting column: it went down while latency doubled, and nothing failed, so the The last commit puts Sorry for the wasted run. Whenever you can re-run it, |
|
/benchmark -f lightning --save |
|
👋 |
|
Bumped to 5.4.0, which is on npm now, so this PR is one thing to approve rather than two: the What is in it that this benchmark can see:
Nothing here should move the other rows outside noise. If any of them does, I would rather hear it |
|
/benchmark -f lightning --save |
|
👋 |
|
/benchmark -f fulmine --save |
|
👋 |
|
there is no "lightning" framework, I think it somehow translated from italian to english lol |
Benchmark ResultsFramework:
Full log |
|
Fulmine = Lightning |
|
Bumped to 5.4.1. The last run's -4..-9% on the query-carrying rows was real, it was mine, and this release removes it. Expected on re-run: baseline, limited-conn, json, json-tls, json-comp and api-4 back to their 5.3.0 numbers, crud staying at ~357k, everything else unchanged. |
|
/benchmark -f fulmine --save |
|
👋 Benchmark request received. A collaborator will review and approve the run. |
|
|
|
Merged Same expectation as before: |
|
👋 Benchmark request received. A collaborator will review and approve the run. |
|
Bumped again, to 5.5.0, which is on npm. Nothing in it changes what this benchmark exercises: it adds Expectation for the run is unchanged: The branch is mergeable with main as of the merge two commits back. |
Benchmark ResultsFramework:
Full log |
|
It's good for me! 🎉 |
Pin bump for the fulmine entry, from
^5.2.0to^5.3.0(changelog).The release is mostly compatibility work: 27 fixes, nearly all of them found by a differential fuzzer that builds random applications and compares the answers against real Express. Nothing there should move a benchmark row.
Four changes do touch the request path, each measured on our own rig against the previous revision, so I have no prediction for yours:
on()twice, -6.9% CPU per request on a hello-worldReadableuntil something asks for one, -5.2% and -5.5% over two runsreq.ipNo entry files change other than the pin.