Bump fulmine to 5.5.2 - #1098
Merged
Merged
Conversation
nigrosimone
marked this pull request as ready for review
August 11, 2026 05:09
nigrosimone
requested review from
Kaliumhexacyanoferrat and
MDA2AV
as code owners
August 11, 2026 05:09
Contributor
Author
|
benchmark -f fulmine --save |
nigrosimone
marked this pull request as draft
August 11, 2026 05:19
nigrosimone
marked this pull request as ready for review
August 11, 2026 05:20
Owner
|
/benchmark -f fulmine --save |
Contributor
|
👋 Benchmark request received. A collaborator will review and approve the run. |
Contributor
Benchmark ResultsFramework:
Full log |
Contributor
Author
|
The Bytes per response went 1562 to 1374, so the size term is 1.29 against 0.84 on rps. Against the field's current minBpr of 1107 the profile score goes 16.6 to 18.6. Still well short of the 1107 the leader ships, so there is more left there, but brotli above q3 gets very slow on payloads this small and stopped paying for itself. |
MDA2AV
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin bump for the fulmine entry, from
^5.5.0to^5.5.2(changelog), plus three changes to the entry.In the release, measured here against the previous revision:
usewith no path ran a regex on every hop for a mount prefix that was always 0. Removing it is -16.8% CPU per request on a chain of 100 middlewares, 23.1k to 27.6k req/sIn the entry:
/staticis served on the TLS listener as well, so it subscribes tostatic-tls, same handler as the plaintext one.proxy/, so it subscribes togateway-64andgateway-h3. Caddy terminates TLS and serves/static/*from disk, the server keeps the three dynamic endpoints it already had, reached over loopback h1. I ran both stacks locally against the repo certs: h2 and h3 both negotiate,/staticcomes from the proxy with the right content types and a 404 for a missing file, and/baseline2,/json/Nand/async-dball answer through it.json-compprefers brotli, which it never reached before becauseAccept-Encoding: gzip, brmatched gzip first. On these payloads q3 is 12% smaller than gzip level 1 for about 24us more per request, and with the score squaring the body size that should come out ahead, but it is a model and not your rig, so the run decides./benchmark -f fulmine --save