[roda] Let Symbol#to_s return a frozen string#987
Merged
Conversation
Contributor
Author
|
/benchmark -f roda |
Contributor
|
👋 |
Contributor
Benchmark ResultsFramework:
Full log |
Contributor
Author
|
/benchmark -f roda --save |
Contributor
|
👋 |
Contributor
|
|
This should reduce string allocations. Large codebases like Shopify and GitHub run this in production: https://bugs.ruby-lang.org/issues/22137 This is how Ruby 4.1 works: ruby/ruby#17781
p8
force-pushed
the
roda/alias-symbol-to-s
branch
from
July 12, 2026 17:03
226f875 to
c0632ab
Compare
Contributor
Author
|
/benchmark -f roda --save |
Contributor
|
👋 |
Contributor
Benchmark ResultsFramework:
Full log |
MDA2AV
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should reduce string allocations.
Large codebases like Shopify and GitHub run this in production: https://bugs.ruby-lang.org/issues/22137
This is how Ruby 4.1 works:
ruby/ruby#17781