-
Notifications
You must be signed in to change notification settings - Fork 22
update deployment workflow #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- fix #153 - replaced MDAnalysis/pypi-deployment action with explicit steps (see also MDAnalysis/pypi-deployment#11 for details on issues) - include full tests of installed packages
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #154 +/- ##
=======================================
Coverage 88.20% 88.20%
=======================================
Files 5 5
Lines 814 814
Branches 107 107
=======================================
Hits 718 718
Misses 56 56
Partials 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
force pushed the 1.1.0a tag for testing deployment |
|
Testing packaged version failed https://github.com/MDAnalysis/GridDataFormats/actions/runs/21233099346/job/61095392408 |
MRC files were left out from the distribution in PR #149. This commit adds them via explicit inclusion pattern in the pyproject.toml file
|
|
If anyone else merges: please do not squash but merge as separate commits. They all do different things and address different issues that came up. |
.github/workflows/deploy.yaml
Outdated
| - name: Set up Python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: "3.x" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would specify a version here - otherwise you'll pick up the latest version (which you might not always be ready for).
IAlibay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks - sorry this is very much a super quick "during a meeting" review
|
Will do a bit more testing before merging. |
d7592fd to
2e469ae
Compare
2e469ae to
fb4dac0
Compare
- run on Python 3.14 - test deployed packages on ubuntu and macos latest fail-fast: false to allow others to run so that we can see tests on different OSs succeeding/failing - concurrency: allow push/tag and release runs to both complete Co-authored-by: Irfan Alibay <ialibay@mdanalysis.org>
fb4dac0 to
80afbd2
Compare
|
Deployment Workflows correctly deploy to PyPi and TestPyPi and download for testing under ubuntu and macOS. However, at the moment they do not reliably test the installed version. I'll raise an issue for that but in the meantime move forward with merging. |
Uh oh!
There was an error while loading. Please reload this page.