fix(test): move test_local_install legend back to right side#31
Merged
Conversation
The Stommel demo generated by 'make test-package' (test_stommel.html) had its legend placed above the plot via add_legend(p, position='above'), which compresses the plot vertically and pushes the title and toolbar out of useful range for a legend that long. Restoring position='right' keeps the legend outside the plot area in a vertical column where it was previously.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One-line fix: change
add_legend(p, position="above", ...)→position="right"intests/test_local_install.py.This script is run by
make test-packageand producestest_stommel.html— the canonical embeddable demo of the package post-install. With the legend above the plot, the legend column compressed the plot vertically; moving it back to the right keeps it outside the plot area in a vertical column.Files changed
tests/test_local_install.py(1 line)Verified
add_legend(..., position="above")in the repoReplaces
Closed PR #29, which mistakenly added a separate
docs/build_demo_boyd.pyinstead of fixing the existing demo. This is the actual fix.