Dependency: Downgrade NLR-rex - #462
Merged
Merged
Conversation
Contributor
Author
MHKiT v1.1.2: Dependency ImprovementsBug Fixes
|
Contributor
Author
Contributor
Author
jmcvey3
approved these changes
Aug 7, 2026
jmcvey3
left a comment
Contributor
There was a problem hiding this comment.
This is working on my end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, the installing mhkit 1.1.1 yields a failed instillation caused by the bitshuffle package as detailed in #461. The root cause appears to be the new
NLR-rex[hsds]dependency in both pyproject.toml and environment-dev.ymlThis reverts to an older version and removes the
hsdsextra which is not required.Additionally
NLR-rexis not available on conda-forge, while an older version of NREL-rex is available. An issue was submitted to NLR-rex: NatLabRockies/rex#229, but our team does not have an eta on a conda-forge of NLR-rex.This also adds tests for wheel builds on windows in an attempt to catch this build error during CI/CD.