Skip to content

Dependency: Downgrade NLR-rex - #462

Merged
simmsa merged 3 commits into
MHKiT-Software:developfrom
simmsa:fix_downgrade_rex
Aug 7, 2026
Merged

Dependency: Downgrade NLR-rex#462
simmsa merged 3 commits into
MHKiT-Software:developfrom
simmsa:fix_downgrade_rex

Conversation

@simmsa

@simmsa simmsa commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

On Windows, the installing mhkit 1.1.1 yields a failed instillation caused by the bitshuffle package as detailed in #461. The root cause appears to be the new NLR-rex[hsds] dependency in both pyproject.toml and environment-dev.yml

This reverts to an older version and removes the hsds extra which is not required.

Additionally NLR-rex is not available on conda-forge, while an older version of NREL-rex is available. An issue was submitted to NLR-rex: NatLabRockies/rex#229, but our team does not have an eta on a conda-forge of NLR-rex.

This also adds tests for wheel builds on windows in an attempt to catch this build error during CI/CD.

@simmsa
simmsa changed the base branch from main to develop August 7, 2026 20:14
@simmsa

simmsa commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

MHKiT v1.1.2: Dependency Improvements

Bug Fixes

@simmsa
simmsa requested a review from jmcvey3 August 7, 2026 21:19
@simmsa

simmsa commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

@jmcvey3 this should fix #461. Could you pull this branch down and see if you are able to get this installed via pip?

@simmsa

simmsa commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

@jmcvey3 this should fix #461. Could you pull this branch down and see if you are able to get this installed via pip?

I think just doing:

pip install -e ".[all]" is the equivalent command for a local install.

@jmcvey3 jmcvey3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working on my end.

@simmsa
simmsa merged commit 3c8910d into MHKiT-Software:develop Aug 7, 2026
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants