Skip to content

Disable image variant processing - #1522

Merged
jazairi merged 1 commit into
mainfrom
etd-668
Jul 29, 2026
Merged

Disable image variant processing#1522
jazairi merged 1 commit into
mainfrom
etd-668

Conversation

@jazairi

@jazairi jazairi commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Why these changes are being introduced:

Active Storage attempts to load an image
processor gem as part of its initialization, even
if the app does not actively generate variants.
(ETD does not.)

Relevant ticket(s):

How this addresses that need:

This explicitly disables the variant processor
to suppress the Active Storage initialization
error.

Side effects of this change:

If we ever do need image variants, we will need
the image_processing gem (or another image
processor).

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

NO

@mitlib
mitlib temporarily deployed to thesis-submit-pr-1522 July 29, 2026 17:17 Inactive
@coveralls

coveralls commented Jul 29, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 98.25%. remained the same — etd-668 into main

@JPrevost JPrevost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels way too easy. :shipit:

Why these changes are being introduced:

Active Storage attempts to load an image
processor gem as part of its initialization, even
if the app does not actively generate variants.
(ETD does not.)

Relevant ticket(s):

- [ETD-668](https://mitlibraries.atlassian.net/browse/ETD-668)

How this addresses that need:

This explicitly disables the variant processor
to suppress the Active Storage initialization
error.

Side effects of this change:

If we ever *do* need image variants, we will need
the `image_processing` gem (or another image
processor).
@jazairi
jazairi temporarily deployed to thesis-submit-pr-1522 July 29, 2026 20:16 Inactive
@jazairi
jazairi merged commit f641f8c into main Jul 29, 2026
2 checks passed
@jazairi
jazairi deleted the etd-668 branch July 29, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants