Conversation
Why these changes are being introduced: Active Storage attempts to load an image processor gem as part of its initialization, even if the app does not actively generate variants. (ETD does not.) Relevant ticket(s): - [ETD-668](https://mitlibraries.atlassian.net/browse/ETD-668) How this addresses that need: This explicitly disables the variant processor to suppress the Active Storage initialization error. Side effects of this change: If we ever *do* need image variants, we will need the `image_processing` gem (or another image processor).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
Active Storage attempts to load an image
processor gem as part of its initialization, even
if the app does not actively generate variants.
(ETD does not.)
Relevant ticket(s):
How this addresses that need:
This explicitly disables the variant processor
to suppress the Active Storage initialization
error.
Side effects of this change:
If we ever do need image variants, we will need
the
image_processinggem (or another imageprocessor).
Developer
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
NO