Retries resulting in allowed errors are handled#391
Merged
Conversation
Why these changes are being introduced: * If a retry results in an allowed error, these errors should be handled as well. It's important to note that during a retry of a failed action, TIM uses the single-document APIs (i.e., the `index`, `update`, and `delete` methods), which will raise exceptions whereas streaming_bulk(raise_on_error=False) did not. The retry decorator has been updated to re-raise `NotFoundError` and `RequestError` caused by mapper parsing exception so they can be handled by the corresponding `tim.opensearch.bulk_*` methods. How this addresses that need: * `tim.opensearch.bulk_index` handles `RequestError` caused by mapper parsing exception raised from retries * `tim.opensearch.bulk_update` handles `NotFoundError` caused by missing documents and `RequestError` caused by mapper parsing exception raised from retries * `tim.opensearch.bulk_delete` handles `NotFoundError` caused by missing documents Side effects of this change: * None Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/TIMX-639
jonavellecuerdo
force-pushed
the
TIMX-639-retry-raises-allowed-exceptions
branch
from
July 14, 2026 17:48
6f094f9 to
540ae97
Compare
jonavellecuerdo
marked this pull request as ready for review
July 14, 2026 17:51
ehanson8
approved these changes
Jul 14, 2026
ehanson8
left a comment
ehanson8
left a comment
Contributor
There was a problem hiding this comment.
One optional suggestion but this is a clean solution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose and background context
If a retry results in an allowed error, these errors should be handled as well. It's important to note that during a retry of a failed action, TIM uses the single-document APIs (i.e., the
index,update, anddeletemethods), which will raise exceptions whereas streaming_bulk(raise_on_error=False) did not. The retry decorator has been updated to re-raiseNotFoundErrorandRequestErrorcaused by mapper parsing exception so they can be handled by the correspondingtim.opensearch.bulk_*methods.How can a reviewer manually see the effects of these changes?
Review added unit tests.
Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?
Code review