Skip to content

Add tab for Digital Collections - #443

Merged
jazairi merged 2 commits into
mainfrom
use-570
Jul 31, 2026
Merged

Add tab for Digital Collections#443
jazairi merged 2 commits into
mainfrom
use-570

Conversation

@jazairi

@jazairi jazairi commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Why these changes are being introduced:

Digital Collections stakeholders would like an
easier way to view TIMDEX search results for that
platform.

Relevant ticket(s):

How this addresses that need:

This adds a Digital Collections tab that is
gated by the Feature class.

Side effects of this change:

None.

Developer

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

The PR build is connected to TIMDEX dev, so Digital Collections results should be visible.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

Why these changes are being introduced:

Digital Collections stakeholders would like an
easier way to view TIMDEX search results for that
platform.

Relevant ticket(s):

- [USE-570](https://mitlibraries.atlassian.net/browse/USE-570)

How this addresses that need:

This adds a Digital Collections tab that is
gated by the Feature class.

Side effects of this change:

None.
@coveralls

coveralls commented Jul 30, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 30661671501

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage increased (+0.001%) to 98.385%

Details

  • Coverage increased (+0.001%) from the base build.
  • Patch coverage: 3 of 3 lines across 3 files are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 1548
Covered Lines: 1523
Line Coverage: 98.39%
Coverage Strength: 85.66 hits per line

💛 - Coveralls

@qltysh

qltysh Bot commented Jul 30, 2026

Copy link
Copy Markdown

❌ 4 blocking issues (4 total)

Tool Category Rule Count
rubocop Lint Assignment Branch Condition size for query\_timdex is too high. [<10, 21, 17> 28.81/17] 1
rubocop Lint Cyclomatic complexity for query\_timdex is too high. [10/7] 1
rubocop Lint Method has too many lines. [20/10] 1
rubocop Lint Perceived complexity for query\_timdex is too high. [11/8] 1

Comment thread app/models/feature.rb Outdated
Comment thread test/controllers/application_controller_unit_test.rb Outdated
@mitlib
mitlib temporarily deployed to timdex-ui-pi-use-570-holnkas59 July 30, 2026 20:59 Inactive
@jazairi
jazairi temporarily deployed to timdex-ui-pi-use-570-holnkas59 July 30, 2026 21:03 Inactive

@JPrevost JPrevost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the 2 qlty flagged "line is too long" comments are worth cleaning up but I won't block on it.

@jazairi
jazairi temporarily deployed to timdex-ui-pi-use-570-holnkas59 July 31, 2026 20:07 Inactive
@jazairi
jazairi merged commit 92f366e into main Jul 31, 2026
6 checks passed
@jazairi
jazairi deleted the use-570 branch July 31, 2026 20:15
@jazairi

jazairi commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

@JPrevost Thanks for flagging that. FYI, I fixed and merged those without re-review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants