Skip to content

feat: add inline Stellar address validation on destination fields - #39

Merged
MJ-RWA merged 1 commit into
mainfrom
feat/address-validation
Aug 5, 2026
Merged

feat: add inline Stellar address validation on destination fields#39
MJ-RWA merged 1 commit into
mainfrom
feat/address-validation

Conversation

@MJ-RWA

@MJ-RWA MJ-RWA commented Aug 5, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

@vercel

vercel Bot commented Aug 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
stellarflow Ready Ready Preview Aug 5, 2026 2:29am

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key: "path_instructions"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
📝 Walkthrough

Walkthrough

SendPage validates destination addresses for a leading G and exactly 56 characters. It displays an inline error for invalid input and disables sending while the error exists.

Changes

Destination Address Validation

Layer / File(s) Summary
Validate destination addresses and gate sending
apps/src/pages/SendPage.tsx
SendPage tracks destination-address errors, validates each input value, displays an inline error, and disables sending when the address is invalid.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

  • Stellarflow issue 3 — Both changes update destination-address input handling in SendPage.tsx; this pull request adds the validation and error-state behavior.
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes a clipboard paste button, but the changes validate destination addresses and disable sending for invalid addresses. Update the title to describe destination-address validation and the invalid-address send restriction.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/address-validation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/src/pages/SendPage.tsx`:
- Around line 125-128: Replace the shape-only destination validation in SendPage
with StrKey.isValidEd25519PublicKey, importing StrKey from `@stellar/stellar-sdk`
and applying the same validation to scheduled payment creation. Preserve the
existing destError behavior for invalid and valid addresses, and add coverage
for a 56-character G address with an invalid checksum.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 4bfb9411-14c6-4f05-8a32-46211cd487ec

📥 Commits

Reviewing files that changed from the base of the PR and between 0fa66aa and c48bc83.

📒 Files selected for processing (1)
  • apps/src/pages/SendPage.tsx

Comment thread apps/src/pages/SendPage.tsx
@MJ-RWA
MJ-RWA merged commit aa256dd into main Aug 5, 2026
3 checks passed
@MJ-RWA MJ-RWA changed the title feat: add clipboard paste button to destination address inputs feat: add inline Stellar address validation on destination fields Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add inline address validation on destination fields

1 participant